Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2580783002: Do not generate a duplicate ExternalName class (Closed)

Created:
4 years ago by Kevin Millikin (Google)
Modified:
4 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not generate a duplicate ExternalName class In https://github.com/dart-lang/sdk/commit/f7b6f0cf1c188bbc375de2a37f9a4129cb845428 some of the VM's libraries were modified to work the the analyzer's patching support. This requires the class ExternalName, which used as an annotation, to be present in the SDK. Before: it was injected by dart code as part of a build step. Now, it just appears as code in the SDK and we should not inject a (duplicate) definition. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/9e0a4bc2dfb6a2b9edf4222c5c8264486ac37900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M tools/patch_sdk.dart View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
4 years ago (2016-12-15 10:15:54 UTC) #2
kustermann
LGTM
4 years ago (2016-12-15 10:23:02 UTC) #3
Kevin Millikin (Google)
4 years ago (2016-12-15 10:24:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e0a4bc2dfb6a2b9edf4222c5c8264486ac37900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698