arc: Avoid the resize operation in GetImageForScale() whenever possible

chrome/browser/ui/app_list/arc/arc_app_icon.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_icon.h"
 
 #include <algorithm>
+#include <map>
+#include <memory>
+#include <utility>
+#include <vector>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
+#include "base/lazy_instance.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/task_runner_util.h"
 #include "chrome/browser/image_decoder.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
 #include "chrome/browser/ui/ash/launcher/arc_app_shelf_id.h"
 #include "chrome/grit/component_extension_resources.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/grit/extensions_browser_resources.h"
@@ skipping 71 matching lines @@
  private:
   // gfx::ImageSkiaSource overrides:
   gfx::ImageSkiaRep GetImageForScale(float scale) override;
 
   // Used to load images asynchronously. NULLed out when the ArcAppIcon is
   // destroyed.
   base::WeakPtr<ArcAppIcon> host_;
 
   const int resource_size_in_dip_;
 
+  // A map from a pair of a resource ID and size in DIP to an image. This
+  // is a cache to avoid resizing IDR icons in GetImageForScale every time.
+  static base::LazyInstance<std::map<std::pair<int, int>, gfx::ImageSkia>>
+      default_icons_cache_;
+
   DISALLOW_COPY_AND_ASSIGN(Source);
 };
 
+base::LazyInstance<std::map<std::pair<int, int>, gfx::ImageSkia>>
+    ArcAppIcon::Source::default_icons_cache_ = LAZY_INSTANCE_INITIALIZER;
+
 ArcAppIcon::Source::Source(const base::WeakPtr<ArcAppIcon>& host,
                            int resource_size_in_dip)
     : host_(host),
       resource_size_in_dip_(resource_size_in_dip) {
 }
 
 ArcAppIcon::Source::~Source() {
 }
 
 gfx::ImageSkiaRep ArcAppIcon::Source::GetImageForScale(float scale) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   if (host_)
     host_->LoadForScaleFactor(ui::GetSupportedScaleFactor(scale));
 
   // Host loads icon asynchronously, so use default icon so far.
   int resource_id;
   if (host_ && host_->app_id() == arc::kPlayStoreAppId) {
     resource_id = scale >= 1.5f ?
         IDR_ARC_SUPPORT_ICON_96 : IDR_ARC_SUPPORT_ICON_48;
   } else {
     resource_id = IDR_APP_DEFAULT_ICON;
   }
+
+  // Check |default_icons_cache_| and returns the existing one if possible.
+  const auto key = std::make_pair(resource_id, resource_size_in_dip_);
+  const auto it = default_icons_cache_.Get().find(key);
+  if (it != default_icons_cache_.Get().end())
+    return it->second.GetRepresentation(scale);
+
   const gfx::ImageSkia* default_image = ResourceBundle::GetSharedInstance().
       GetImageSkiaNamed(resource_id);
   CHECK(default_image);
-  return gfx::ImageSkiaOperations::CreateResizedImage(
-      *default_image,
-      skia::ImageOperations::RESIZE_BEST,
-      gfx::Size(resource_size_in_dip_, resource_size_in_dip_)).
-          GetRepresentation(scale);
+  gfx::ImageSkia resized_image = gfx::ImageSkiaOperations::CreateResizedImage(
+      *default_image, skia::ImageOperations::RESIZE_BEST,
+      gfx::Size(resource_size_in_dip_, resource_size_in_dip_));
+
+  // Add the resized image to the cache to avoid executing the expensive resize
+  // operation many times. Caching the result is safe because unlike ARC icons
+  // that can be updated dynamically, IDR icons are static.
+  default_icons_cache_.Get().insert(std::make_pair(key, resized_image));
+  return resized_image.GetRepresentation(scale);
 }
 
 class ArcAppIcon::DecodeRequest : public ImageDecoder::ImageRequest {
  public:
   DecodeRequest(const base::WeakPtr<ArcAppIcon>& host,
                 int dimension,
                 ui::ScaleFactor scale_factor);
   ~DecodeRequest() override;
 
   // ImageDecoder::ImageRequest
@@ skipping 193 matching lines @@
 
 void ArcAppIcon::DiscardDecodeRequest(DecodeRequest* request) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   ScopedVector<DecodeRequest>::iterator it = std::find(decode_requests_.begin(),
                                                        decode_requests_.end(),
                                                        request);
   CHECK(it != decode_requests_.end());
   decode_requests_.erase(it);
 }