Issue 258073003: Added HttpUrlRequestListener OnResponseStarted callback.

Issue 258073003: Added HttpUrlRequestListener OnResponseStarted callback. (Closed)

Created:
6 years, 7 months ago by mef

Modified:
6 years, 7 months ago

Reviewers:
Charles, mmenke, fnk_

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added HttpUrlRequestListener OnResponseStarted callback. BUG=354143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266741

Patch Set 1 #

Patch Set 2 : Move mListener.onResponseStarted to the end of onResponseStarted. #

Patch Set 3 : Fix newlines. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
M	components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

chromium-reviews

You might want to call the listener at the very end of the method, after ...

6 years, 7 months ago (2014-04-28 17:22:57 UTC) #2

You might want to call the listener at the very end of the method, after
updating the fields.


Fedor Kouranov | Software Warlord |  fnk@google.com |  617-359-3517


On Mon, Apr 28, 2014 at 1:10 PM, <mef@chromium.org> wrote:

> Reviewers: fnk_google.com,
>
> Message:
> would this work?
>
> Description:
> Added HttpUrlRequestListener OnResponseStarted callback.
>
> BUG=354143
>
> Please review this at https://codereview.chromium.org/258073003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+15, -0 lines):
>   M components/cronet/android/java/src/org/chromium/net/
> ChromiumUrlRequest.java
>   M components/cronet/android/java/src/org/chromium/net/
> HttpUrlRequestListener.java
>   M components/cronet/android/sample/src/org/chromium/cronet_sample_apk/
> CronetSampleActivity.java
>
>
> Index: components/cronet/android/java/src/org/chromium/net/
> ChromiumUrlRequest.java
> diff --git
a/components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java
> b/components/cronet/android/java/src/org/chromium/net/
> ChromiumUrlRequest.java
> index 1679dc2a1518f5a0a87fa411597be6cba6225ef4..
> 2c80b717d545511f153f51f56faae332f3dc9226 100644
> --- a/components/cronet/android/java/src/org/chromium/net/
> ChromiumUrlRequest.java
> +++ b/components/cronet/android/java/src/org/chromium/net/
> ChromiumUrlRequest.java
> @@ -88,6 +88,8 @@ class ChromiumUrlRequest extends UrlRequest implements
> HttpUrlRequest {
>      protected void onResponseStarted() {
>          super.onResponseStarted();
>
> +        mListener.onResponseStarted(this);
> +
>          mContentLength = super.getContentLength();
>          if (mContentLengthLimit > 0 && mContentLength >
> mContentLengthLimit
>                  && mCancelIfContentLengthOverLimit) {
> Index: components/cronet/android/java/src/org/chromium/net/
> HttpUrlRequestListener.java
> diff --git
a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestListener.java
> b/components/cronet/android/java/src/org/chromium/net/
> HttpUrlRequestListener.java
> index 00b9c9392055bde112bf87ea819f2914e568063e..
> 01e1e829d80a9a10f124b2972347647e00f05406 100644
> --- a/components/cronet/android/java/src/org/chromium/net/
> HttpUrlRequestListener.java
> +++ b/components/cronet/android/java/src/org/chromium/net/
> HttpUrlRequestListener.java
> @@ -9,6 +9,12 @@ package org.chromium.net;
>   */
>  public interface HttpUrlRequestListener {
>      /**
> +     * A callback invoked when the first chunk of the response has
> arrived.
> +     * The listener can only call request getContentType and
> getContentLength.
> +     */
> +    void onResponseStarted(HttpUrlRequest request);
> +
> +    /**
>       * The listener should completely process the response in the callback
>       * method. Immediately after the callback, the request object will be
>       * recycled.
> Index: components/cronet/android/sample/src/org/chromium/
> cronet_sample_apk/CronetSampleActivity.java
> diff --git a/components/cronet/android/sample/src/org/chromium/
> cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/
> sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
> index 4dd9d48a6397e8150a9447edfad969c9ef4a3558..
> 9b9000a55358cc9fb9e319b3d0c1aafda624541f 100644
> --- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/
> CronetSampleActivity.java
> +++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/
> CronetSampleActivity.java
> @@ -90,6 +90,13 @@ public class CronetSampleActivity extends Activity {
>          }
>
>          @Override
> +        public void onResponseStarted(HttpUrlRequest request) {
> +            Log.i(TAG, "****** Response Started, content length is "
> +                    + request.getContentLength());
> +
> +        }
> +
> +        @Override
>          public void onRequestComplete(HttpUrlRequest request) {
>              Log.i(TAG, "****** Request Complete, status code is "
>                      + getHttpStatusCode());
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.