Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended. (Closed)
Patch Set: revert no longer needed test change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index c0258ffea3528dc98818208be8287cea9124c381..0b681365b6483499f7a792a2c6db2bb44fe85dbd 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -4110,6 +4110,29 @@ TEST_P(WebViewTest, NestedPageSuspensions) {
EXPECT_FALSE(webView->page()->suspended());
}
+TEST_P(WebViewTest, ClosingPageIsSuspended) {
+ WebViewImpl* webView = m_webViewHelper.initialize();
+ Page* page = m_webViewHelper.webView()->page();
+ EXPECT_FALSE(page->suspended());
+
+ webView->setOpenedByDOM();
+
+ LocalFrame* mainFrame = toLocalFrame(page->mainFrame());
+ EXPECT_FALSE(mainFrame->domWindow()->closed());
+
+ mainFrame->domWindow()->close(nullptr);
+ // The window should be marked closed...
+ EXPECT_TRUE(mainFrame->domWindow()->closed());
+ // EXPECT_TRUE(page->isClosing());
+ // ...but not yet detached.
+ EXPECT_TRUE(mainFrame->host());
+
+ {
+ ScopedPageSuspender suspender;
+ EXPECT_TRUE(page->suspended());
+ }
+}
+
TEST_P(WebViewTest, ForceAndResetViewport) {
URLTestHelpers::registerMockedURLFromBaseURL(
WebString::fromUTF8(m_baseURL.c_str()),

Powered by Google App Engine
This is Rietveld 408576698