third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended. (Closed)

Patch Set: revert no longer needed test change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index c3389570cdb07f16d4a8bf2ba1dc726d5c2efc61..1aec0f32fb4a38331772e5678d006944da4142fd 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -477,12 +477,6 @@ bool ChromeClientImpl::openBeforeUnloadConfirmPanelDelegate(LocalFrame* frame,

}

void ChromeClientImpl::closeWindowSoon() {

- // Make sure this Page can no longer be found by JS.

- m_webView->page()->willBeClosed();

- // Make sure that all loading is stopped. Ensures that JS stops executing!

- m_webView->mainFrame()->stopLoading();

if (m_webView->client())

m_webView->client()->closeWidgetSoon();

}