third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended. (Closed)

Patch Set: revert no longer needed test change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index b6f4c38a4ae1f3e604b4756cd84ccd68be1bc48b..84c469ea2d1e8e361998d35c00430d83a8d4554e 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -396,7 +396,7 @@ void DOMWindow::close(ExecutionContext* context) {

InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(context, "close",

true);

- page->chromeClient().closeWindowSoon();

+ page->closeSoon();

// So as to make window.closed return the expected result

// after window.close(), separately record the to-be-closed