third_party/WebKit/Source/core/page/FrameTree.cpp - Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 2580703003: Make sure pages that are closing but not yet closed are still suspended. (Closed)

Patch Set: comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/FrameTree.cpp

diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp

index 6ec877110709deef111a9fa6563e6c4cc59bc561..85bcb3422b274e357f1f87ed039d03dcafe958b5 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.cpp

+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp

@@ -430,7 +430,7 @@ Frame* FrameTree::find(const AtomicString& name) const {

// Search the entire tree of each of the other pages in this namespace.

// FIXME: Is random order OK?

for (const Page* otherPage : Page::ordinaryPages()) {

- if (otherPage == page)

+ if (otherPage == page || otherPage->isClosing())

dcheng 2016/12/15 19:11:38 Another alternative is to check the main frame's w

continue;

for (Frame* frame = otherPage->mainFrame(); frame;

frame = frame->tree().traverseNext()) {