Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js

Issue 2580673002: [DevTools] Introduce typed events. (Closed)
Patch Set: [DevTools] Introduce typed events. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
index 782d23d58a720da0beb322feeed4b11daca34f4f..4b2220fc3a13d62d137303d0256b1a2aaf95a3bc 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
@@ -134,8 +134,8 @@ Resources.ResourcesPanel = class extends UI.PanelWithSidebar {
this._target = target;
this._databaseModel = Resources.DatabaseModel.fromTarget(target);
- this._databaseModel.addEventListener(Resources.DatabaseModel.Events.DatabaseAdded, this._databaseAdded, this);
- this._databaseModel.addEventListener(Resources.DatabaseModel.Events.DatabasesRemoved, this._resetWebSQL, this);
+ this._databaseModel.on(Resources.DatabaseModel.DatabaseAddedEvent, this._databaseAdded, this);
+ this._databaseModel.on(Resources.DatabaseModel.DatabasesRemovedEvent, this._resetWebSQL, this);
var resourceTreeModel = SDK.ResourceTreeModel.fromTarget(target);
if (!resourceTreeModel)
@@ -164,8 +164,8 @@ Resources.ResourcesPanel = class extends UI.PanelWithSidebar {
resourceTreeModel.removeEventListener(
SDK.ResourceTreeModel.Events.WillLoadCachedResources, this._resetWithFrames, this);
}
- this._databaseModel.removeEventListener(Resources.DatabaseModel.Events.DatabaseAdded, this._databaseAdded, this);
- this._databaseModel.removeEventListener(Resources.DatabaseModel.Events.DatabasesRemoved, this._resetWebSQL, this);
+ this._databaseModel.off(Resources.DatabaseModel.DatabaseAddedEvent, this._databaseAdded, this);
+ this._databaseModel.off(Resources.DatabaseModel.DatabasesRemovedEvent, this._resetWebSQL, this);
this._resetWithFrames();
}
@@ -382,19 +382,11 @@ Resources.ResourcesPanel = class extends UI.PanelWithSidebar {
}
/**
- * @param {!Common.Event} event
+ * @param {!Resources.DatabaseModel.DatabaseAddedEvent} event
*/
_databaseAdded(event) {
- var database = /** @type {!Resources.Database} */ (event.data);
- this._addDatabase(database);
- }
-
- /**
- * @param {!Resources.Database} database
- */
- _addDatabase(database) {
- var databaseTreeElement = new Resources.DatabaseTreeElement(this, database);
- this._databaseTreeElements.set(database, databaseTreeElement);
+ var databaseTreeElement = new Resources.DatabaseTreeElement(this, event.database);
+ this._databaseTreeElements.set(event.database, databaseTreeElement);
this.databasesListTreeElement.appendChild(databaseTreeElement);
}

Powered by Google App Engine
This is Rietveld 408576698