[MD settings] remove selectedSite property

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration mapping all possible controlled-by values for exceptions to
  * icons.
  * @enum {string}
  */
 var iconControlledBy = {
@@ skipping 17 matching lines @@
   properties: {
     /** @private */
     enableSiteSettings_: {
       type: Boolean,
       value: function() {
         return loadTimeData.getBoolean('enableSiteSettings');
       },
     },
 
     /**
-     * The site that was selected by the user in the dropdown list.
-     * @type {SiteException}
-     */
-    selectedSite: {
-      type: Object,
-      notify: true,
-    },
-
-    /**
      * The site serving as the model for the currently open action menu.
      * @private {?SiteException}
      */
     actionMenuSite_: Object,
 
     /**
      * Array of sites to display in the widget.
      * @type {!Array<SiteException>}
      */
     sites: {
@@ skipping 340 matching lines @@
   },
 
   /**
    * A handler for selecting a site (by clicking on the origin).
    * @param {!{model: !{item: !SiteException}}} event
    * @private
    */
   onOriginTap_: function(event) {
     if (!this.enableSiteSettings_)
       return;
-    this.selectedSite = event.model.item;
+    this.selectedSiteForUnitTest = event.model.item;

[tommycli, 2016/12/16 00:39:49]

I think you can also eliminate this by testing for the 'site' key in
URLSearchParams.

https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route....

Also - I assume you double checked my conjecture that selectedSite is indeed not
needed?

[dschuyler, 2016/12/16 01:11:57]

Done.

     settings.navigateTo(settings.Route.SITE_SETTINGS_SITE_DETAILS,
-        new URLSearchParams('site=' + this.selectedSite.origin));
+        new URLSearchParams('site=' + event.model.item.origin));
   },
 
   /**
    * A handler for activating one of the menu action items.
    * @param {string} action The permission to set (Allow, Block, SessionOnly,
    *     etc).
    * @private
    */
   onActionMenuActivate_: function(action) {
     var origin = this.actionMenuSite_.origin;
@@ skipping 62 matching lines @@
                 Polymer.dom(/** @type {!Event} */ (e)).localTarget));
   },
 
   /** @private */
   closeActionMenu_: function() {
     this.actionMenuSite_ = null;
     /** @type {!CrActionMenuElement} */ (
         this.$$('dialog[is=cr-action-menu]')).close();
   },
 });