Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258063009: retry r266622: (Closed)

Created:
6 years, 7 months ago by Evan Stade
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+views_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

retry r266622: --------------------- Automatically call OnNativeThemeChanged when a widget is added to a hierarchy with a widget. Split off from https://codereview.chromium.org/245863002/ BUG=347832 (tangentially) --------------------- original review: https://codereview.chromium.org/251703002/ changes: fix uninitialized reads Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267034

Patch Set 1 #

Patch Set 2 : initialize color values #

Total comments: 2

Patch Set 3 : revert Label changes completely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -142 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 12 chunks +42 lines, -72 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 4 chunks +28 lines, -22 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M ui/views/view.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M ui/views/view_unittest.cc View 4 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
patchset 1 is the original patch. patchset 2 is the new patch (there's only one ...
6 years, 7 months ago (2014-04-28 22:51:41 UTC) #1
sky
https://codereview.chromium.org/258063009/diff/20001/ui/views/controls/label.cc File ui/views/controls/label.cc (right): https://codereview.chromium.org/258063009/diff/20001/ui/views/controls/label.cc#newcode400 ui/views/controls/label.cc:400: OnNativeThemeChanged(ui::NativeTheme::instance()); Won't this end up invoking a virtual function ...
6 years, 7 months ago (2014-04-28 23:22:14 UTC) #2
Evan Stade
https://codereview.chromium.org/258063009/diff/20001/ui/views/controls/label.cc File ui/views/controls/label.cc (right): https://codereview.chromium.org/258063009/diff/20001/ui/views/controls/label.cc#newcode400 ui/views/controls/label.cc:400: OnNativeThemeChanged(ui::NativeTheme::instance()); On 2014/04/28 23:22:15, sky wrote: > Won't this ...
6 years, 7 months ago (2014-04-29 19:20:26 UTC) #3
sky
Yes, against style file. LGTM without that change.
6 years, 7 months ago (2014-04-29 19:28:03 UTC) #4
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-29 19:33:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/258063009/40001
6 years, 7 months ago (2014-04-29 19:35:12 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 01:41:00 UTC) #7
Message was sent while issue was closed. 
Change committed as 267034

Powered by Google App Engine
This is Rietveld 408576698