Use 41% of screen height as all system VK height

Use 41% of screen height as all system VK height


Previously, accessibility keyboard uses 30 percent of screen
height as its height and compact keyboard uses 41 percent.

The IME VKs always use 41 percent for both full and compact
keyboards. This CL uses 41 percent for all system virtual
keyboards to make it consistent with IME VKs.


BUG=367947
TEST=
1. in about://flags disable input view flag and enable virtual
keyboard flag
2. click any text input area
3. a 4 rows virtual keyboard should show up and will occupy
about 41 percent of screen
4. enable accessibility virtual keyboard in chrome://settings
5. refocus a text input area
6. a 5 rows virtual keyboard should show up and will occupy
about 41 percent of screen

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266986

[bshe, 2014-04-28 19:36:40]

Another small fix for system keyboard size issue.

Thanks!

[kevers, 2014-04-28 20:07:53]

https://codereview.chromium.org/258063006/diff/1/ui/keyboard/resources/consta...
File ui/keyboard/resources/constants.js (right):

https://codereview.chromium.org/258063006/diff/1/ui/keyboard/resources/consta...
ui/keyboard/resources/constants.js:71: var DEFAULT_A11Y_KEYBOARD_ASPECT_RATIO =
0.3;
Should be consistent with size of extension IME based VKs, which appears to be
41% for both the compact and the full layout.

[bshe, 2014-04-28 20:32:36]

PTAL. Thanks!

https://codereview.chromium.org/258063006/diff/1/ui/keyboard/resources/consta...
File ui/keyboard/resources/constants.js (right):

https://codereview.chromium.org/258063006/diff/1/ui/keyboard/resources/consta...
ui/keyboard/resources/constants.js:71: var DEFAULT_A11Y_KEYBOARD_ASPECT_RATIO =
0.3;
On 2014/04/28 20:07:53, kevers wrote:
> Should be consistent with size of extension IME based VKs, which appears to be
> 41% for both the compact and the full layout.

Done.

[kevers, 2014-04-28 20:33:31]

lgtm

[bshe, 2014-04-28 20:38:09]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:39:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/258063006/60001

[commit-bot: I haz the power, 2014-04-28 21:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:33:50]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[bshe, 2014-04-28 21:38:33]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-04-28 21:39:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/258063006/60001

[commit-bot: I haz the power, 2014-04-28 22:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 22:27:06]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[bshe, 2014-04-29 14:26:43]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-04-29 14:27:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/258063006/60001

[commit-bot: I haz the power, 2014-04-29 22:53:30]

Change committed as 266986