Source/core/html/HTMLTextFormControlElement.h - Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.h

Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the changes asked for LayoutTests in patch set 3 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html ('K') | « LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd-expected.txt ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextFormControlElement.h

diff --git a/Source/core/html/HTMLTextFormControlElement.h b/Source/core/html/HTMLTextFormControlElement.h

index 576c867f86d1cc426354eebe492b319dd837e699..fd41ac95c7cb0df49434e37b752ae2e14234a642 100644

--- a/Source/core/html/HTMLTextFormControlElement.h

+++ b/Source/core/html/HTMLTextFormControlElement.h

@@ -60,6 +60,8 @@ public:

int indexForVisiblePosition(const VisiblePosition&) const;

int selectionStart() const;

int selectionEnd() const;

+ int selectionStartForJavascriptBindings() const;

+ int selectionEndForJavascriptBindings() const;

const AtomicString& selectionDirection() const;

void setSelectionStart(int);

void setSelectionEnd(int);