Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added some changes in patch set 2 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/forms/TextFieldInputType.cpp
diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp
index 1b78abe81c6802df9dd34458a9f75859217cdbb0..b83ced0e037f274fb4a10e88b4aa1b53455545c7 100644
--- a/Source/core/html/forms/TextFieldInputType.cpp
+++ b/Source/core/html/forms/TextFieldInputType.cpp
@@ -157,11 +157,11 @@ void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChange
if (valueChanged)
input->updateView();
- unsigned max = visibleValue().length();
+ int max = visibleValue().length();
if (input->focused())
input->setSelectionRange(max, max);
else
- input->cacheSelectionInResponseToSetValue(max);
+ input->setSelectionRange(input->selectionStartForJavascriptBindings(), input->selectionEndForJavascriptBindings());
if (!valueChanged)
return;

Powered by Google App Engine
This is Rietveld 408576698