LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html - Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases

Side by Side Diff: LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html

Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing changes asked in patch set 5 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <input id="val1" type="text" />

	8 <input id="val2" type="text" />

	9 <script type="text/javascript">

	10 description('Test for BUG=367736: Blink does not respect input.selectionStart an d input.selectionEnd for some cases.');

	11 var firstInput = document.getElementById('val1');

	12 var secondInput = document.getElementById('val2');

	13 if (!window.testRunner) {
	tkent 2014/05/20 09:51:40 This test doesn't need testRunner. This test doesn't need testRunner.
	14 debug('This test needs window.testRunner to work.');

	15 } else {

	16 firstInput.selectionStart = 3;

	17 firstInput.selectionEnd = 5;

	18 firstInput.value = "Parsed";
	tkent 2014/05/20 09:51:40 nit: double-quotes though other quotes are single. nit: double-quotes though other quotes are single.
	19 shouldBe('firstInput.selectionStart', '6');
	harpreet.sk 2014/05/19 11:16:52 I checked this case on the browser and it was show I checked this case on the browser and it was showing correct value of selectionStart as 3 and selectionEnd as 5 but when i ran this test on test runner it shows selectionStart and selectionEnd value to be 6. I dont know why test runner is returning such value. Can you please tell why it's happening? tkent 2014/05/20 09:51:40 I don't know. Please investigate by yourself. Show quoted text On 2014/05/19 11:16:52, harpreet.sk wrote: > I checked this case on the browser and it was showing correct value of > selectionStart as 3 and selectionEnd as 5 but when i ran this test on test > runner it shows selectionStart and selectionEnd value to be 6. I dont know why > test runner is returning such value. Can you please tell why it's happening? I don't know. Please investigate by yourself. harpreet.sk 2014/05/23 10:46:24 I found that whenver we give test file as an input Show quoted text On 2014/05/20 09:51:40, tkent wrote: > On 2014/05/19 11:16:52, harpreet.sk wrote: > > I checked this case on the browser and it was showing correct value of > > selectionStart as 3 and selectionEnd as 5 but when i ran this test on test > > runner it shows selectionStart and selectionEnd value to be 6. I dont know why > > test runner is returning such value. Can you please tell why it's happening? > > I don't know. Please investigate by yourself. I found that whenver we give test file as an input it focused the input field first. That's the reason why test runner is showing such values. Consider the following source code: <!DOCTYPE html> <html> <head> </head> <body> <input id="val1" type="text" /> <script type="text/javascript"> var input = document.getElementById('val1'); input.selectionStart = 3; </script> </body> </html> If you simply load the following source code you will only see unfocused input field. But if you open the page by giving file name as input (out/Release/chrome file.html) or run it with test runner it focused the field. Even if you simply first open page and then refresh it it will focus the input field. Is it a bug that test runner behaves differently than browser for given case?
	20 shouldBe('firstInput.selectionEnd', '6');

	21 secondInput.selectionStart = 3;

	22 secondInput.selectionEnd = 5;

	23 secondInput.value = "P";
	tkent 2014/05/20 09:51:40 nit: double-quotes nit: double-quotes
	24 shouldBe('secondInput.selectionStart', '1');

	25 shouldBe('secondInput.selectionEnd', '1');

	26 secondInput.value = "Parsed";
	tkent 2014/05/20 09:51:40 nit: double-quotes nit: double-quotes
	27 shouldBe('secondInput.selectionStart', '6');
	harpreet.sk 2014/05/19 11:16:52 Ditto. I think test runner always returns selectio Ditto. I think test runner always returns selectionStart/End equal to the length of input.value
	28 shouldBe('secondInput.selectionEnd', '6');

	29 }

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd-expected.txt » ('j') | no next file with comments »