Blink does not respect input.selectionStart and input.selectionEnd for some cases

Source/core/html/forms/TextFieldInputType.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 142 matching lines @@
     RefPtrWillBeRawPtr<HTMLInputElement> input(element());
 
     // We don't ask InputType::setValue to dispatch events because
     // TextFieldInputType dispatches events different way from InputType.
     InputType::setValue(sanitizedValue, valueChanged, DispatchNoEvent);
 
     if (valueChanged)
         input->updateView();
 
     unsigned max = visibleValue().length();
-    if (input->focused())
+    if (input->focused() && input->selectionStart() == input->selectionEnd())

[tkent, 2014/07/08 00:34:48]

Why is |input->selectionStart() == input->selectionEnd()| necessary?

[harpreet.sk, 2014/07/08 06:07:59]

This was the part of old change but it is not required now, hence removing this
check.

         input->setSelectionRange(max, max);
     else
-        input->cacheSelectionInResponseToSetValue(max);
+        input->setSelectionRange(input->selectionStart(), input->selectionEnd());
+

[tkent, 2014/07/08 00:34:48]

nit: This blank line change is unnecessary.

[harpreet.sk, 2014/07/08 06:07:59]

Done.

 
     if (!valueChanged)
         return;
 
     switch (eventBehavior) {
     case DispatchChangeEvent:
         // If the user is still editing this field, dispatch an input event rather than a change event.
         // The change event will be dispatched when editing finishes.
         if (input->focused())
             input->dispatchFormControlInputEvent();
@@ skipping 377 matching lines @@
     return shouldSpinButtonRespondToMouseEvents() && element().focused();
 }
 
 void TextFieldInputType::spinButtonDidReleaseMouseCapture(SpinButtonElement::EventDispatch eventDispatch)
 {
     if (eventDispatch == SpinButtonElement::EventDispatchAllowed)
         element().dispatchFormControlChangeEvent();
 }
 
 } // namespace WebCore