Source/core/html/HTMLTextFormControlElement.h - Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.h

Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patch fixing existing bug Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/forms/validationMessage-expected.txt ('K') | « LayoutTests/fast/forms/validationMessage-expected.txt ('k') | Source/core/html/HTMLTextFormControlElement.cpp » ('j') | Source/core/html/HTMLTextFormControlElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.

6 * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.	6 * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 virtual bool supportsPlaceholder() const = 0;	53 virtual bool supportsPlaceholder() const = 0;

54 String strippedPlaceholder() const;	54 String strippedPlaceholder() const;

55 bool placeholderShouldBeVisible() const;	55 bool placeholderShouldBeVisible() const;

56 HTMLElement* placeholderElement() const;	56 HTMLElement* placeholderElement() const;

57 void updatePlaceholderVisibility(bool);	57 void updatePlaceholderVisibility(bool);

58	58

59 VisiblePosition visiblePositionForIndex(int) const;	59 VisiblePosition visiblePositionForIndex(int) const;

60 int indexForVisiblePosition(const VisiblePosition&) const;	60 int indexForVisiblePosition(const VisiblePosition&) const;

61 int selectionStart() const;	61 int selectionStart() const;

62 int selectionEnd() const;	62 int selectionEnd() const;

	63 int selectionStartForJavascriptBindings() const;

	64 int selectionEndForJavascriptBindings() const;

63 const AtomicString& selectionDirection() const;	65 const AtomicString& selectionDirection() const;

64 void setSelectionStart(int);	66 void setSelectionStart(int);

65 void setSelectionEnd(int);	67 void setSelectionEnd(int);

66 void setSelectionDirection(const String&);	68 void setSelectionDirection(const String&);

67 void select();	69 void select();

68 virtual void setRangeText(const String& replacement, ExceptionState&);	70 virtual void setRangeText(const String& replacement, ExceptionState&);

69 virtual void setRangeText(const String& replacement, unsigned start, unsigne d end, const String& selectionMode, ExceptionState&);	71 virtual void setRangeText(const String& replacement, unsigned start, unsigne d end, const String& selectionMode, ExceptionState&);

70 void setSelectionRange(int start, int end, const String& direction);	72 void setSelectionRange(int start, int end, const String& direction);

71 void setSelectionRange(int start, int end, TextFieldSelectionDirection = Sel ectionHasNoDirection);	73 void setSelectionRange(int start, int end, TextFieldSelectionDirection = Sel ectionHasNoDirection);

72 PassRefPtrWillBeRawPtr<Range> selection() const;	74 PassRefPtrWillBeRawPtr<Range> selection() const;

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
142 return element.isTextFormControl();	144 return element.isTextFormControl();

143 }	145 }

144	146

145 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTextFormControlElement);	147 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLTextFormControlElement);

146	148

147 HTMLTextFormControlElement* enclosingTextFormControl(const Position&);	149 HTMLTextFormControlElement* enclosingTextFormControl(const Position&);

148	150

149 } // namespace	151 } // namespace

150	152

151 #endif	153 #endif

OLD	NEW