LayoutTests/fast/forms/input-placeholder-visibility-2-expected.html - Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/input-placeholder-visibility-2-expected.html

Issue 258063005: Blink does not respect input.selectionStart and input.selectionEnd for some cases (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: New patch fixing existing bug Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/selection/5497643.html ('k') | LayoutTests/fast/forms/input-set-selectionStart-set-selectionEnd.html » ('j') | LayoutTests/fast/forms/paste-into-textarea.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 </head>	4 </head>

5 <body>	5 <body>

6 <p>Focus field with a placeholder, then type.</p>	6 <p>Focus field with a placeholder, then type.</p>

7 <div>	7 <div>

8 <input id=i1 value="Text">	8 <input id=i1 value="Text">

9 <script>	9 <script>

10 document.getElementById('i1').setSelectionRange(4, 4);	10 if (!window.testRunner) {

	11 document.write("This test needs testRunner to work")

	12 } else {

	13 var startX = document.getElementById("i1").offsetLeft + 30;
	tkent 2014/06/01 23:40:55 This looks depending on a specific font, and looks This looks depending on a specific font, and looks not portable. document.getElementById('i1').focus(); document.getElementById('i1').setSelectionRange(4, 4); Does this work? harpreet.sk 2014/07/02 10:13:05 Yes it will work. I had made the changes in new pa Show quoted text On 2014/06/01 23:40:55, tkent wrote: > This looks depending on a specific font, and looks not portable. > > document.getElementById('i1').focus(); > document.getElementById('i1').setSelectionRange(4, 4); > > Does this work? Yes it will work. I had made the changes in new patch.
	14 var startY = document.getElementById("i1").offsetTop + 4;

	15 eventSender.mouseMoveTo(startX,startY);

	16 eventSender.mouseDown();

	17 eventSender.mouseUp();

	18 }

11 </script>	19 </script>

12 </body>	20 </body>

13 </html>	21 </html>

OLD	NEW