Issue 2580553002: Disable precache if data_reduction_proxy enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2580553002: Disable precache if data_reduction_proxy enabled. (Closed)

Created:
4 years ago by twifkak

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Disable precache if data_reduction_proxy enabled. Disable precache if data_reduction_proxy is enabled on this client and the disable_if_data_reduction_proxy variation parameter is set (non-empty) on the field trial. BUG=670070 Review-Url: https://codereview.chromium.org/2544613003 Cr-Commit-Position: refs/heads/master@{#437386} (cherry picked from commit 1190ea49edece62ceb6f1b469364fd026134c695) Committed: https://chromium.googlesource.com/chromium/src/+/9fba7008729b569de970fe88b7823950ff55ca2d

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -11 lines)			Patch
M	chrome/browser/precache/precache_manager_factory.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	components/precache/content/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/precache/content/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/precache/content/precache_manager.h	View	3 chunks	+13 lines, -2 lines	0 comments	Download
M	components/precache/content/precache_manager.cc	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	components/precache/content/precache_manager_unittest.cc	View	2 chunks	+13 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

twifkak

4 years ago (2016-12-14 23:20:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9fba7008729b569de970fe88b7823950ff55ca2d.