Chromium Code Reviews| Index: src/interpreter/interpreter-assembler.cc |
| diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc |
| index 8d5eb831166078bb50ceb6bbefb324cb4156795d..feddb2b640e690b240c7e43b597b6fce219d8547 100644 |
| --- a/src/interpreter/interpreter-assembler.cc |
| +++ b/src/interpreter/interpreter-assembler.cc |
| @@ -451,7 +451,7 @@ Node* InterpreterAssembler::BytecodeOperandIntrinsicId(int operand_index) { |
| Node* InterpreterAssembler::LoadConstantPoolEntry(Node* index) { |
| Node* constant_pool = LoadObjectField(BytecodeArrayTaggedPointer(), |
| BytecodeArray::kConstantPoolOffset); |
| - return LoadFixedArrayElement(constant_pool, index, 0, INTPTR_PARAMETERS); |
| + return LoadFixedArrayElement(constant_pool, index); |
| } |
| Node* InterpreterAssembler::LoadAndUntagConstantPoolEntry(Node* index) { |
| @@ -490,13 +490,12 @@ Node* InterpreterAssembler::IncrementCallCount(Node* type_feedback_vector, |
| Node* slot_id) { |
| Comment("increment call count"); |
| Node* call_count_slot = IntPtrAdd(slot_id, IntPtrConstant(1)); |
| - Node* call_count = LoadFixedArrayElement( |
| - type_feedback_vector, call_count_slot, 0, INTPTR_PARAMETERS); |
| + Node* call_count = |
| + LoadFixedArrayElement(type_feedback_vector, call_count_slot); |
| Node* new_count = SmiAdd(call_count, SmiConstant(1)); |
| // Count is Smi, so we don't need a write barrier. |
| return StoreFixedArrayElement(type_feedback_vector, call_count_slot, |
| - new_count, SKIP_WRITE_BARRIER, 0, |
| - INTPTR_PARAMETERS); |
| + new_count, SKIP_WRITE_BARRIER); |
| } |
| Node* InterpreterAssembler::CallJSWithFeedback(Node* function, Node* context, |
| @@ -524,8 +523,7 @@ Node* InterpreterAssembler::CallJSWithFeedback(Node* function, Node* context, |
| end(this); |
| // The checks. First, does function match the recorded monomorphic target? |
| - Node* feedback_element = LoadFixedArrayElement(type_feedback_vector, slot_id, |
| - 0, INTPTR_PARAMETERS); |
| + Node* feedback_element = LoadFixedArrayElement(type_feedback_vector, slot_id); |
| Node* feedback_value = LoadWeakCellValueUnchecked(feedback_element); |
| Node* is_monomorphic = WordEqual(function, feedback_value); |
| GotoUnless(is_monomorphic, &extra_checks); |
| @@ -645,7 +643,7 @@ Node* InterpreterAssembler::CallJSWithFeedback(Node* function, Node* context, |
| StoreFixedArrayElement( |
| type_feedback_vector, slot_id, |
| HeapConstant(TypeFeedbackVector::MegamorphicSentinel(isolate())), |
| - SKIP_WRITE_BARRIER, 0, INTPTR_PARAMETERS); |
| + SKIP_WRITE_BARRIER); |
| Goto(&call); |
| } |
| } |
| @@ -706,8 +704,7 @@ Node* InterpreterAssembler::CallConstruct(Node* constructor, Node* context, |
| GotoUnless(is_js_function, &call_construct); |
| // Check if it is a monomorphic constructor. |
| - Node* feedback_element = LoadFixedArrayElement(type_feedback_vector, slot_id, |
| - 0, INTPTR_PARAMETERS); |
| + Node* feedback_element = LoadFixedArrayElement(type_feedback_vector, slot_id); |
| Node* feedback_value = LoadWeakCellValueUnchecked(feedback_element); |
| Node* is_monomorphic = WordEqual(constructor, feedback_value); |
| allocation_feedback.Bind(UndefinedConstant()); |
| @@ -812,7 +809,7 @@ Node* InterpreterAssembler::CallConstruct(Node* constructor, Node* context, |
| StoreFixedArrayElement( |
| type_feedback_vector, slot_id, |
| HeapConstant(TypeFeedbackVector::MegamorphicSentinel(isolate())), |
| - SKIP_WRITE_BARRIER, 0, INTPTR_PARAMETERS); |
| + SKIP_WRITE_BARRIER); |
| Goto(&call_construct_function); |
| } |
| } |
| @@ -1263,8 +1260,7 @@ Node* InterpreterAssembler::ExportRegisterFile(Node* array) { |
| Node* reg_index = IntPtrSub(IntPtrConstant(Register(0).ToOperand()), index); |
| Node* value = LoadRegister(reg_index); |
| - StoreFixedArrayElement(array, index, value, UPDATE_WRITE_BARRIER, 0, |
| - INTPTR_PARAMETERS); |
| + StoreFixedArrayElement(array, index, value, UPDATE_WRITE_BARRIER); |
|
Jakob Kummerow
2016/12/14 23:42:36
nit: UPDATE_WRITE_BARRIER is the default, you can
Igor Sheludko
2016/12/14 23:46:09
Done.
|
| var_index.Bind(IntPtrAdd(index, IntPtrConstant(1))); |
| Goto(&loop); |
| @@ -1294,13 +1290,12 @@ Node* InterpreterAssembler::ImportRegisterFile(Node* array) { |
| Node* index = var_index.value(); |
| GotoUnless(UintPtrLessThan(index, register_count), &done_loop); |
| - Node* value = LoadFixedArrayElement(array, index, 0, INTPTR_PARAMETERS); |
| + Node* value = LoadFixedArrayElement(array, index); |
| Node* reg_index = IntPtrSub(IntPtrConstant(Register(0).ToOperand()), index); |
| StoreRegister(value, reg_index); |
| - StoreFixedArrayElement(array, index, StaleRegisterConstant(), |
| - UPDATE_WRITE_BARRIER, 0, INTPTR_PARAMETERS); |
| + StoreFixedArrayElement(array, index, StaleRegisterConstant()); |
| var_index.Bind(IntPtrAdd(index, IntPtrConstant(1))); |
| Goto(&loop); |