cc: Fix PictureLayerImpl::SanityCheck condition

cc: Fix PictureLayerImpl::SanityCheck condition

PictureLayerImpl::ReleaseResources calls
set_needs_update_draw_properties, expecting as a result that if it is
false again, that CalculateContentsScale is called in between. However
this assumption is not true as CalculateDrawProperties can skip layers.

Instead, also check should_update_tile_priorities_ which is set in
CalculateContentsScale.

BUG=358350
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266813

[boliu, 2014-04-28 23:41:39]

ptal

[enne (OOO), 2014-04-28 23:45:27]

lgtm, thanks.  I guess we can see if there are other crashes after this and try
to pin down another repro case.

https://codereview.chromium.org/258053011/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258053011/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:681: // When the tree is up to date, the set of
tilings must either be empty or
Can you just move this comment and check into the block below that has the same
conditional?

[boliu, 2014-04-28 23:50:38]

Yep. I'll let you know if I get any android webview reports.

https://codereview.chromium.org/258053011/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258053011/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:681: // When the tree is up to date, the set of
tilings must either be empty or
On 2014/04/28 23:45:28, enne wrote:
> Can you just move this comment and check into the block below that has the
same
> conditional?

Done.

[boliu, 2014-04-28 23:50:58]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-04-28 23:53:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/258053011/20001

[commit-bot: I haz the power, 2014-04-29 09:47:35]

Change committed as 266813