Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/renderer/gpu/queue_message_swap_promise_unittest.cc

Issue 2580493002: Splitting DidSwap in cc::SwapPromise into WillSwap and DidSwap (Closed)
Patch Set: x Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/gpu/queue_message_swap_promise.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/gpu/queue_message_swap_promise_unittest.cc
diff --git a/content/renderer/gpu/queue_message_swap_promise_unittest.cc b/content/renderer/gpu/queue_message_swap_promise_unittest.cc
index cc8777b6adbc3427f11989a43ae2a4701182f07b..3f6d7561fa010f441716eb46635439de10103e1d 100644
--- a/content/renderer/gpu/queue_message_swap_promise_unittest.cc
+++ b/content/renderer/gpu/queue_message_swap_promise_unittest.cc
@@ -120,7 +120,8 @@ class QueueMessageSwapPromiseTest : public testing::Test {
++i) {
if (*i) {
(*i)->DidActivate();
- (*i)->DidSwap(NULL);
+ (*i)->WillSwap(NULL);
+ (*i)->DidSwap();
}
}
}
@@ -150,11 +151,12 @@ TEST_F(QueueMessageSwapPromiseTest, NextSwapPolicySchedulesMessageForNextSwap) {
ASSERT_TRUE(promises_[0]);
promises_[0]->DidActivate();
- promises_[0]->DidSwap(NULL);
+ promises_[0]->WillSwap(NULL);
+ promises_[0]->DidSwap();
EXPECT_TRUE(DirectSendMessages().empty());
EXPECT_FALSE(frame_swap_message_queue_->Empty());
- // frame_swap_message_queue_->DidSwap(1);
+ // frame_swap_message_queue_->WillSwap(1);
EXPECT_TRUE(NextSwapHasMessage(messages_[0]));
}
@@ -254,7 +256,8 @@ TEST_F(QueueMessageSwapPromiseTest, VisualStateSwapPromiseDidActivate) {
QueueMessages(data, arraysize(data));
promises_[0]->DidActivate();
- promises_[0]->DidSwap(NULL);
+ promises_[0]->WillSwap(NULL);
+ promises_[0]->DidSwap();
ASSERT_FALSE(promises_[1]);
std::vector<std::unique_ptr<IPC::Message>> messages;
messages.swap(NextSwapMessages());
« no previous file with comments | « content/renderer/gpu/queue_message_swap_promise.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698