Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: cc/trees/swap_promise_manager_unittest.cc

Issue 2580493002: Splitting DidSwap in cc::SwapPromise into WillSwap and DidSwap (Closed)
Patch Set: x Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/layer_tree_impl_unittest.cc ('k') | content/renderer/gpu/queue_message_swap_promise.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/swap_promise_manager.h" 5 #include "cc/trees/swap_promise_manager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "cc/trees/swap_promise_monitor.h" 8 #include "cc/trees/swap_promise_monitor.h"
9 #include "testing/gmock/include/gmock/gmock.h" 9 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 13 matching lines...) Expand all
24 void OnSetNeedsRedrawOnImpl() override {} 24 void OnSetNeedsRedrawOnImpl() override {}
25 void OnForwardScrollUpdateToMainThreadOnImpl() override {} 25 void OnForwardScrollUpdateToMainThreadOnImpl() override {}
26 }; 26 };
27 27
28 class MockSwapPromise : public SwapPromise { 28 class MockSwapPromise : public SwapPromise {
29 public: 29 public:
30 MockSwapPromise() {} 30 MockSwapPromise() {}
31 ~MockSwapPromise() override {} 31 ~MockSwapPromise() override {}
32 32
33 void DidActivate() override {} 33 void DidActivate() override {}
34 void DidSwap(CompositorFrameMetadata* metadata) override {} 34 void WillSwap(CompositorFrameMetadata* metadata) override {}
35 void DidSwap() override {}
35 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override { 36 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override {
36 return DidNotSwapAction::BREAK_PROMISE; 37 return DidNotSwapAction::BREAK_PROMISE;
37 } 38 }
38 MOCK_METHOD0(OnCommit, void()); 39 MOCK_METHOD0(OnCommit, void());
39 int64_t TraceId() const override { return 0; } 40 int64_t TraceId() const override { return 0; }
40 }; 41 };
41 42
42 TEST(SwapPromiseManagerTest, SwapPromiseMonitors) { 43 TEST(SwapPromiseManagerTest, SwapPromiseMonitors) {
43 SwapPromiseManager manager; 44 SwapPromiseManager manager;
44 StrictMock<MockSwapPromiseMonitor> monitor(&manager); 45 StrictMock<MockSwapPromiseMonitor> monitor(&manager);
(...skipping 18 matching lines...) Expand all
63 std::vector<std::unique_ptr<SwapPromise>> swap_promise_list = 64 std::vector<std::unique_ptr<SwapPromise>> swap_promise_list =
64 manager.TakeSwapPromises(); 65 manager.TakeSwapPromises();
65 // Now that we've taken the promises, this shouldn't trigger a call. 66 // Now that we've taken the promises, this shouldn't trigger a call.
66 manager.WillCommit(); 67 manager.WillCommit();
67 68
68 EXPECT_EQ(1, static_cast<int>(swap_promise_list.size())); 69 EXPECT_EQ(1, static_cast<int>(swap_promise_list.size()));
69 } 70 }
70 71
71 } // namespace 72 } // namespace
72 } // namespace cc 73 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/layer_tree_impl_unittest.cc ('k') | content/renderer/gpu/queue_message_swap_promise.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698