Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2580403002: Extract ClosedWorldImpl from WorldImpl. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -248 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 2 chunks +15 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 2 chunks +34 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 14 chunks +315 lines, -229 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
Johnni Winther
4 years ago (2016-12-19 14:32:10 UTC) #3
Johnni Winther
ping
4 years ago (2016-12-20 08:36:06 UTC) #4
Siggi Cherem (dart-lang)
lgtm, nice to see this split! https://codereview.chromium.org/2580403002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2580403002/diff/1/pkg/compiler/lib/src/world.dart#newcode494 pkg/compiler/lib/src/world.dart:494: reporter.internalError(cls, 'Class "${cls.name}" ...
4 years ago (2016-12-20 15:36:36 UTC) #5
Johnni Winther
https://codereview.chromium.org/2580403002/diff/1/pkg/compiler/lib/src/world.dart File pkg/compiler/lib/src/world.dart (right): https://codereview.chromium.org/2580403002/diff/1/pkg/compiler/lib/src/world.dart#newcode494 pkg/compiler/lib/src/world.dart:494: reporter.internalError(cls, 'Class "${cls.name}" is not resolved.'); On 2016/12/20 15:36:36, ...
4 years ago (2016-12-21 08:41:25 UTC) #6
Johnni Winther
4 years ago (2016-12-21 08:47:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3f977cb5d18b7cbedd91b16a2176e396fa96487a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698