Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2580353002: Make ClosedWorld a `forTesting` property of ResolutionWorldBuilder. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make ClosedWorld a `forTesting` property of ResolutionWorldBuilder. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b13bb540e36593117cb45ffb7dcd0a7287b0f307

Patch Set 1 #

Patch Set 2 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 4 chunks +4 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 3 chunks +14 lines, -1 line 0 comments Download
M tests/compiler/dart2js/assert_message_throw_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/concrete_type_inference_test.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/dump_info_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/expect_annotations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/related_types.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_callers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/simple_inferrer_no_such_method_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_mask_disjoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years ago (2016-12-19 13:35:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-12-20 01:00:37 UTC) #3
Johnni Winther
4 years ago (2016-12-20 08:58:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b13bb540e36593117cb45ffb7dcd0a7287b0f307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698