Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258033006: Add git revision info to the titlebar (Closed)

Created:
6 years, 7 months ago by jcgregorio
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add git revision info to the titlebar BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14407

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M experimental/webtry/css/webtry.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M experimental/webtry/templates/index.html View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/recent.html View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/titlebar.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M experimental/webtry/templates/workspace.html View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/webtry.go View 1 2 3 8 chunks +35 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 7 months ago (2014-04-28 14:52:57 UTC) #1
mtklein
https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go#newcode172 experimental/webtry/webtry.go:172: // M include/core/SkDynamicAnnotations.h Hey, I know this change... https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go#newcode182 ...
6 years, 7 months ago (2014-04-28 15:06:20 UTC) #2
jcgregorio
https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go#newcode182 experimental/webtry/webtry.go:182: gitInfo = logInfo[1] + " " + logInfo[2] + ...
6 years, 7 months ago (2014-04-28 15:11:56 UTC) #3
mtklein
On 2014/04/28 15:11:56, jcgregorio wrote: > https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go > File experimental/webtry/webtry.go (right): > > https://codereview.chromium.org/258033006/diff/20001/experimental/webtry/webtry.go#newcode182 > ...
6 years, 7 months ago (2014-04-28 15:14:07 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-04-28 15:19:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/258033006/60001
6 years, 7 months ago (2014-04-28 15:19:29 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 15:33:37 UTC) #7
Message was sent while issue was closed. 
Change committed as 14407

Powered by Google App Engine
This is Rietveld 408576698