Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: test/cctest/test-flags.cc

Issue 2580323002: [debug-wrapper] remove last uses of --expose-debug-as (Closed)
Patch Set: address comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/debugger/debug/regress/regress-617882.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 CHECK_EQ(42, FLAG_testing_int_flag); 245 CHECK_EQ(42, FLAG_testing_int_flag);
246 CHECK_EQ(0, FLAG_js_arguments.argc); 246 CHECK_EQ(0, FLAG_js_arguments.argc);
247 } 247 }
248 248
249 249
250 TEST(FlagsRemoveIncomplete) { 250 TEST(FlagsRemoveIncomplete) {
251 // Test that processed command line arguments are removed, even 251 // Test that processed command line arguments are removed, even
252 // if the list of arguments ends unexpectedly. 252 // if the list of arguments ends unexpectedly.
253 SetFlagsToDefault(); 253 SetFlagsToDefault();
254 int argc = 3; 254 int argc = 3;
255 const char* argv[] = { "", "--crankshaft", "--expose-debug-as" }; 255 const char* argv[] = {"", "--crankshaft", "--expose-natives-as"};
256 CHECK_EQ(2, FlagList::SetFlagsFromCommandLine(&argc, 256 CHECK_EQ(2, FlagList::SetFlagsFromCommandLine(&argc,
257 const_cast<char **>(argv), 257 const_cast<char **>(argv),
258 true)); 258 true));
259 CHECK(argv[1]); 259 CHECK(argv[1]);
260 CHECK_EQ(argc, 2); 260 CHECK_EQ(argc, 2);
261 } 261 }
OLDNEW
« no previous file with comments | « test/cctest/test-debug.cc ('k') | test/debugger/debug/regress/regress-617882.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698