 Chromium Code Reviews
 Chromium Code Reviews Issue 2580323002:
  [debug-wrapper] remove last uses of --expose-debug-as  (Closed)
    
  
    Issue 2580323002:
  [debug-wrapper] remove last uses of --expose-debug-as  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. | 
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without | 
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are | 
| 4 // met: | 4 // met: | 
| 5 // | 5 // | 
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright | 
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. | 
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above | 
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following | 
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided | 
| 11 // with the distribution. | 11 // with the distribution. | 
| 12 // * Neither the name of Google Inc. nor the names of its | 12 // * Neither the name of Google Inc. nor the names of its | 
| 13 // contributors may be used to endorse or promote products derived | 13 // contributors may be used to endorse or promote products derived | 
| 14 // from this software without specific prior written permission. | 14 // from this software without specific prior written permission. | 
| 15 // | 15 // | 
| 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 
| 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 
| 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 
| 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 
| 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 
| 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 
| 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 
| 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 
| 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 
| 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 
| 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 
| 27 | 27 | 
| 28 // Flags: --expose-debug-as debug | |
| 29 // Get the Debug object exposed from the debug context global object. | 28 // Get the Debug object exposed from the debug context global object. | 
| 30 Debug = debug.Debug | 29 Debug = debug.Debug | 
| 31 var exception = false; | 30 var exception = false; | 
| 32 var state = 0; | 31 var state = 0; | 
| 33 | 32 | 
| 34 function listener(event, exec_state, event_data, data) { | 33 function listener(event, exec_state, event_data, data) { | 
| 35 try { | 34 try { | 
| 36 if (event == Debug.DebugEvent.Break) { | 35 if (event == Debug.DebugEvent.Break) { | 
| 37 var line = event_data.sourceLineText(); | 36 var line = event_data.sourceLineText(); | 
| 38 print('break: ' + line); | 37 print('break: ' + line); | 
| 39 assertEquals('// BREAK', line.substr(-8), | 38 assertEquals('// BREAK', line.substr(-8), | 
| 40 "should not break outside evaluate"); | 39 "should not break outside evaluate"); | 
| 41 | 40 | 
| 42 switch (state) { | 41 switch (state) { | 
| 43 case 0: | 42 case 0: | 
| 44 state = 1; | 43 state = 1; | 
| 45 // While in the debugger and stepping through a set of instructions | 44 // While in the debugger and stepping through a set of instructions | 
| 46 // executed in the evaluate command, the stepping must stop at the end | 45 // executed in the evaluate command, the stepping must stop at the end | 
| 47 // of the said set of instructions and not step further into native | 46 // of the said set of instructions and not step further into native | 
| 48 // debugger code. | 47 // debugger code. | 
| 49 exec_state.frame(0).evaluate( | 48 exec_state.frame(0).evaluate( | 
| 50 "print('A');\n" + | 49 "print('A');\n" + | 
| 51 "debugger; // BREAK\n" + | 50 "debugger;\n" + | 
| 52 "print('B'); // BREAK"); | 51 "print('B');"); | 
| 53 break; | 52 break; | 
| 54 case 1: | 53 case 1: | 
| 55 exec_state.prepareStep(Debug.StepAction.StepNext); | 54 exec_state.prepareStep(Debug.StepAction.StepNext); | 
| 
jgruber
2016/12/19 09:46:33
If I understand correctly, this case isn't hit any
 
Yang
2016/12/19 10:04:10
Correct. Replaced with assertUnreachable.
 | |
| 56 break; | 55 break; | 
| 57 } | 56 } | 
| 58 } | 57 } | 
| 59 } catch (e) { | 58 } catch (e) { | 
| 60 print(e); | 59 print(e); | 
| 61 exception = true; | 60 exception = true; | 
| 62 } | 61 } | 
| 63 } | 62 } | 
| 64 | 63 | 
| 65 // Add the debug event listener. | 64 // Add the debug event listener. | 
| 66 Debug.setListener(listener); | 65 Debug.setListener(listener); | 
| 67 | 66 | 
| 68 function a() { | 67 function a() { | 
| 69 } // BREAK | 68 } // BREAK | 
| 70 | 69 | 
| 71 // Set a break point and call to invoke the debug event listener. | 70 // Set a break point and call to invoke the debug event listener. | 
| 72 Debug.setBreakPoint(a, 0, 0); | 71 Debug.setBreakPoint(a, 0, 0); | 
| 73 a(); | 72 a(); | 
| 74 assertFalse(exception); | 73 assertFalse(exception); | 
| OLD | NEW |