mediaview: Mount ARC documents provider file system volumes.

components/arc/arc_service_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 #define COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/observer_list.h"
 #include "base/task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "components/arc/intent_helper/activity_icon_loader.h"
 #include "components/arc/intent_helper/local_activity_resolver.h"
 
 namespace arc {
 
 class ArcBridgeService;
+class ArcFileSystemService;
 class ArcIntentHelperObserver;
 class ArcService;
 
 // Manages creation and destruction of services that communicate with the ARC
 // instance via the ArcBridgeService.
 class ArcServiceManager {
  public:
   class Observer {
    public:
     // Called when ArcServiceManager is being shut down. Observer
     // implementation should clean up ARC related stuff here. One of the
     // typical use cases is calling ArcServiceManager::RemoveObserver().
-    virtual void OnArcShutdown() = 0;
+    virtual void OnArcShutdown() {}

[Luis Héctor Chávez, 2017/01/10 18:51:35]

nit: can you leave them as they were before? we want people to try not to use
it, and having them all as = 0 introduces a desirable amount of friction.

[Shuhei Takahashi, 2017/01/11 15:20:43]

Done.

 
     // Called when intent filters are added or removed.
-    virtual void OnIntentFiltersUpdated() = 0;
+    virtual void OnIntentFiltersUpdated() {}
 
    protected:
     virtual ~Observer() = default;
   };
 
   explicit ArcServiceManager(
       scoped_refptr<base::TaskRunner> blocking_task_runner);
   ~ArcServiceManager();
 
   // |arc_bridge_service| can only be accessed on the thread that this
@@ skipping 18 matching lines @@
   }
 
   // Returns the icon loader owned by ArcServiceManager and shared by services.
   scoped_refptr<ActivityIconLoader> icon_loader() { return icon_loader_; }
 
   // Returns the activity resolver owned by ArcServiceManager.
   scoped_refptr<LocalActivityResolver> activity_resolver() {
     return activity_resolver_;
   }
 
-  // Returns the IntentHelperObserver instance owned by ArcServiceManager.
+  // Returns the ArcIntentHelperObserver instance owned by ArcServiceManager.
   ArcIntentHelperObserver* intent_helper_observer() {
     return intent_helper_observer_.get();
   }
 
+  // TODO(crbug.com/672840): Implement a generic getter to avoid boilerplates.
+  void set_file_system_service(ArcFileSystemService* file_system_service) {
+    file_system_service_ = file_system_service;
+  }
+  ArcFileSystemService* file_system_service() const {
+    return file_system_service_;
+  }
+
  private:
   class IntentHelperObserverImpl;  // implemented in arc_service_manager.cc.
 
   base::ThreadChecker thread_checker_;
   scoped_refptr<base::TaskRunner> blocking_task_runner_;
 
   // An object for observing the ArcIntentHelper instance in |services_|.
   std::unique_ptr<ArcIntentHelperObserver> intent_helper_observer_;
 
   std::unique_ptr<ArcBridgeService> arc_bridge_service_;
   std::vector<std::unique_ptr<ArcService>> services_;
   scoped_refptr<ActivityIconLoader> icon_loader_;
   scoped_refptr<LocalActivityResolver> activity_resolver_;
 
+  ArcFileSystemService* file_system_service_;  // Owned by |services_|.
+
   base::ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcServiceManager);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_