mediaview: Mount ARC documents provider file system volumes.

chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/fileapi/arc_documents_provider_util.h"
 
 #include <vector>
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "net/base/escape.h"
 #include "storage/browser/fileapi/file_system_url.h"
 #include "url/gurl.h"
 
 namespace arc {
 
 const char kDocumentsProviderMountPointName[] = "arc-documents-provider";
 const base::FilePath::CharType kDocumentsProviderMountPointPath[] =
     "/special/arc-documents-provider";
 const char kAndroidDirectoryMimeType[] = "vnd.android.document/directory";
 
+base::FilePath GetDocumentsProviderMountPath(

[mtomasz, 2017/01/11 09:35:22]

Is this going to be reused for any document provider? If, so then
root_document_id can be anything, and should be escaped.

[Shuhei Takahashi, 2017/01/12 08:20:28]

Right, done.

+    const std::string& authority,
+    const std::string& root_document_id) {
+  return base::FilePath(kDocumentsProviderMountPointPath)
+      .Append(authority)
+      .Append(root_document_id);
+}
+
 bool ParseDocumentsProviderUrl(const storage::FileSystemURL& url,
                                std::string* authority,
                                std::string* root_document_id,

[mtomasz, 2017/01/11 09:35:22]

nit: Is the returned root_document_id escaped or not? Can we add a comment in
the header file?

[Shuhei Takahashi, 2017/01/12 08:20:28]

Done.

                                base::FilePath* path) {
   if (url.type() != storage::kFileSystemTypeArcDocumentsProvider)
     return false;
   base::FilePath url_path_stripped = url.path().StripTrailingSeparators();
 
   if (!base::FilePath(kDocumentsProviderMountPointPath)
            .IsParent(url_path_stripped)) {
     return false;
   }
 
   // Filesystem URL format for documents provider is:
   // /special/arc-documents-provider/<authority>/<root_doc_id>/<relative_path>
   std::vector<base::FilePath::StringType> components;
   url_path_stripped.GetComponents(&components);
   if (components.size() < 5)
     return false;
 
   *authority = components[3];
   *root_document_id = components[4];
 
-  base::FilePath root_path = base::FilePath(kDocumentsProviderMountPointPath)
-                                 .Append(*authority)
-                                 .Append(*root_document_id);
+  base::FilePath root_path =
+      GetDocumentsProviderMountPath(*authority, *root_document_id);
   // Special case: AppendRelativePath() fails for identical paths.
   if (url_path_stripped == root_path) {
     path->clear();
   } else {
     bool success = root_path.AppendRelativePath(url_path_stripped, path);
     DCHECK(success);
   }
   return true;
 }
 
 GURL BuildDocumentUrl(const std::string& authority,
                       const std::string& document_id) {
   return GURL(base::StringPrintf(
       "content://%s/document/%s",
       net::EscapeQueryParamValue(authority, false /* use_plus */).c_str(),
       net::EscapeQueryParamValue(document_id, false /* use_plus */).c_str()));
 }
 
 }  // namespace arc