mediaview: Mount ARC documents provider file system volumes.

chrome/browser/chromeos/arc/arc_service_launcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_service_launcher.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 80 matching lines @@
   arc_service_manager_->AddService(
       base::MakeUnique<ArcAuthService>(arc_bridge_service));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcBluetoothBridge>(arc_bridge_service));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcBootErrorNotification>(arc_bridge_service));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcBootPhaseMonitorBridge>(arc_bridge_service));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcClipboardBridge>(arc_bridge_service));
-  arc_service_manager_->AddService(
-      base::MakeUnique<ArcFileSystemService>(arc_bridge_service));
+  auto file_system_service =
+      base::MakeUnique<ArcFileSystemService>(arc_bridge_service);
+  // We don't have to call ArcFileSystemService::RemoveObserver() in
+  // ~ArcServiceManager() since the observer in ArcServiceManager always
+  // outlives the ArcFileSystemService object.
+  file_system_service->AddObserver(

[Luis Héctor Chávez, 2017/01/10 05:49:04]

This looks kind of weird. Can we either:

a) Preferred: create a small interface in components/arc that has
Add/RemoveObserver(ArcFileSystemObserver*), and have ArcServiceManager expose
that directly so that the volume_manager can subscribe to ArcFileSystemObserver
events directly instead of ArcServiceManager re-emit all the events, which does
not scale well and might get out of hand if you want to add more events. This
might become easier and less boilerplatey if we land something like
https://codereview.chromium.org/2622843002
a) Make this a Delegate instead so we can pass it to ArcFileSystemService's
constructor.

+      arc_service_manager_->file_system_observer());
+  arc_service_manager_->AddService(std::move(file_system_service));
   arc_service_manager_->AddService(base::MakeUnique<ArcCrashCollectorBridge>(
       arc_bridge_service, arc_service_manager_->blocking_task_runner()));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcDownloadsWatcherService>(arc_bridge_service));
   arc_service_manager_->AddService(
       base::MakeUnique<ArcEnterpriseReportingService>(arc_bridge_service));
   auto intent_helper = base::MakeUnique<ArcIntentHelperBridge>(
       arc_bridge_service, arc_service_manager_->icon_loader(),
       arc_service_manager_->activity_resolver());
   // We don't have to call ArcIntentHelperBridge::RemoveObserver() in
@@ skipping 49 matching lines @@
 
 void ArcServiceLauncher::Shutdown() {
   DCHECK(arc_service_manager_);
   // Destroy in the reverse order of the initialization.
   arc_service_manager_->Shutdown();
   arc_session_manager_.reset();
   arc_service_manager_.reset();
 }
 
 }  // namespace arc