MacViews: Select word under cursor on right click.

ui/views/selection_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/selection_controller.h"
 
 #include <algorithm>
 
 #include "ui/events/event.h"
 #include "ui/gfx/render_text.h"
@@ skipping 38 matching lines @@
           delegate_->SetTextBeingDragged(true);
         } else {
           delegate_->OnBeforePointerAction();
           const bool selection_changed =
               render_text->MoveCursorTo(event.location(), event.IsShiftDown());
           delegate_->OnAfterPointerAction(false, selection_changed);
         }
         break;
       case 1:
         // Select the word at the click location on a double click.
-        delegate_->OnBeforePointerAction();
-        render_text->MoveCursorTo(event.location(), false);
-        render_text->SelectWord();
-        delegate_->OnAfterPointerAction(false, true);
+        SelectWord(event.location());
         double_click_word_ = render_text->selection();
         break;
       case 2:
         // Select all the text on a triple click.
         delegate_->OnBeforePointerAction();
         render_text->SelectAll(false);
         delegate_->OnAfterPointerAction(false, true);
         break;
       default:
         NOTREACHED();
     }
   }
 
+  const bool select_word_on_right_click =
+      event.IsOnlyRightMouseButton() &&
+      PlatformStyle::kSelectWordOnRightClick &&
+      !render_text->IsPointInSelection(event.location());
+  if (select_word_on_right_click)
+    SelectWord(event.location());

[tapted, 2016/12/19 06:49:16]

There's another NSTextField behaviour related to this that we don't seem to get
right. That is: When right-clicking a text field when another control in the
window has focus, we should select _all_ the text. Fixing that may influence the
control flow we want here as well (and the names we choose e.g. maybe
kAlterSelectionOnRightClick )

[karandeepb, 2016/12/19 07:05:43]

Yeah had pointed this out in the comment with the previous patchset. As you
said, this'll probably require changing the control flow, maybe even adding a
RequestFocus method to the SelectionControllerDelegate. If it's ok, I think it
can be implemented separately.

[tapted, 2016/12/20 00:12:42]

I couldn't find this comment - can you send me a link?

If we're not incorporating it now, there should be a TODO() here to note that
this is incomplete, with a link to the bug about selecting the whole text when
it doesn't have focus.

[karandeepb, 2016/12/21 14:20:02]

I was referring to the comment with the initial PTAL message. Copying it here - 
"PTAL Trent. Another Mac specific behavior I observed is that right clicking on
an unfocused text view, selects all the text. However, there are still some bugs
relating to focus and retaining selection, hence I am not implementing that for
now."
Done. Still have to think how to incorporate this behavior since currently focus
is requested by the SelectionController clients. 

+
   if (handles_selection_clipboard_ && event.IsOnlyMiddleMouseButton()) {
     if (render_text->IsPointInSelection(event.location())) {
       delegate_->OnBeforePointerAction();
       render_text->ClearSelection();
       delegate_->UpdateSelectionClipboard();
       delegate_->OnAfterPointerAction(false, true);
     } else if (!delegate_->IsReadOnly()) {
       delegate_->OnBeforePointerAction();
       const bool selection_changed =
           render_text->MoveCursorTo(event.location(), false);
       const bool text_changed = delegate_->PasteSelectionClipboard();
       delegate_->OnAfterPointerAction(text_changed,
                                       selection_changed | text_changed);
     }
   }
 
   return true;
 }
 
+void SelectionController::SelectWord(const gfx::Point& point) {
+  gfx::RenderText* render_text = GetRenderText();
+  DCHECK(render_text);
+  delegate_->OnBeforePointerAction();
+  render_text->MoveCursorTo(point, false);
+  render_text->SelectWord();
+  delegate_->OnAfterPointerAction(false, true);
+}
+
 bool SelectionController::OnMouseDragged(const ui::MouseEvent& event) {
   DCHECK(GetRenderText());
   // If |drag_selection_timer_| is running, |last_drag_location_| will be used
   // to update the selection.
   last_drag_location_ = event.location();
 
   // Don't adjust the cursor on a potential drag and drop.
   if (delegate_->HasTextBeingDragged() || !event.IsOnlyLeftMouseButton())
     return true;
 
@@ skipping 99 matching lines @@
         std::max(selection.GetMax(), double_click_word_.GetMax());
     const bool reversed = selection.is_reversed();
     selection.set_start(reversed ? max : min);
     selection.set_end(reversed ? min : max);
     render_text->SelectRange(selection);
   }
   delegate_->OnAfterPointerAction(false, true);
 }
 
 }  // namespace views