Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2580133002: Fix directory existence query error (Closed)

Created:
4 years ago by zra
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use ENOTDIR. Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M runtime/bin/directory_android.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/directory_fuchsia.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 1 chunk +21 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years ago (2016-12-16 23:59:54 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/2580133002/diff/1/runtime/bin/directory_android.cc File runtime/bin/directory_android.cc (right): https://codereview.chromium.org/2580133002/diff/1/runtime/bin/directory_android.cc#newcode356 runtime/bin/directory_android.cc:356: errno = ENOENT; Consider ENOTDIR.
4 years ago (2016-12-17 00:06:14 UTC) #3
zra
https://codereview.chromium.org/2580133002/diff/1/runtime/bin/directory_android.cc File runtime/bin/directory_android.cc (right): https://codereview.chromium.org/2580133002/diff/1/runtime/bin/directory_android.cc#newcode356 runtime/bin/directory_android.cc:356: errno = ENOENT; On 2016/12/17 00:06:14, rmacnak wrote: > ...
4 years ago (2016-12-17 04:58:06 UTC) #4
zra
4 years ago (2016-12-17 04:58:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a9193990312774ea19c3bc4a69de3c3defc2af64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698