Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: nss.gyp

Issue 258013011: Disable Intel AES assembly code on Windows because of memory corruption (Closed) Base URL: http://src.chromium.org/svn/trunk/deps/third_party/nss
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: nss.gyp
diff --git a/nss.gyp b/nss.gyp
index f25145222f663fddfa33a4d6f897ee5647f5f608..d3be663701ad3760f1c10aef876e5b06b1aa5023 100644
--- a/nss.gyp
+++ b/nss.gyp
@@ -1171,7 +1171,13 @@
'MP_ASSEMBLY_DIV_2DX1D',
'MP_USE_UINT_DIGIT',
'MP_NO_MP_WORD',
- 'USE_HW_AES',
+ ],
+ # intel-gcm-x86-masm.asm seems to corrupt memory, so disable all
+ # Intel AES assembly code. (http://crbug.com/367515)
+ 'sources!': [
+ 'nss/lib/freebl/intel-aes-x86-masm.asm',
+ 'nss/lib/freebl/intel-gcm-wrap.c',
+ 'nss/lib/freebl/intel-gcm-x86-masm.asm',
],
'msvs_settings': {
'MASM': {
@@ -1194,7 +1200,7 @@
'nss/lib/freebl/intel-aes-x86-masm.asm',
'nss/lib/freebl/intel-gcm-wrap.c',
'nss/lib/freebl/intel-gcm-x64-masm.asm',
- 'nss/lib/freebl/intel-aes-x86-masm.asm',
+ 'nss/lib/freebl/intel-gcm-x86-masm.asm',
'nss/lib/freebl/mpi/mpi_amd64.c',
'nss/lib/freebl/mpi/mpi_x86_asm.c',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698