Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 258010: Reverting 27759. (Closed)

Created:
11 years, 2 months ago by jorlow
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Another stab at the Chromium side of storage events. Re-submission of http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27943

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -48 lines) Patch
M chrome/browser/in_process_webkit/browser_webkitclient_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/in_process_webkit/browser_webkitclient_impl.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_context.h View 1 2 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_context.cc View 1 2 5 chunks +38 lines, -1 line 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h View 1 2 3 chunks +38 lines, -2 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc View 1 2 6 chunks +63 lines, -6 lines 0 comments Download
M chrome/browser/in_process_webkit/storage_namespace.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/in_process_webkit/storage_namespace.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/in_process_webkit/webkit_context.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/in_process_webkit/webkit_context.cc View 1 2 1 chunk +10 lines, -17 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 2 5 chunks +11 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 5 chunks +16 lines, -0 lines 0 comments Download
M chrome/renderer/renderer_webstoragenamespace_impl.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M webkit/api/public/WebKitClient.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
A webkit/api/public/WebStorageEventDispatcher.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M webkit/api/src/StorageEventDispatcherChromium.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A webkit/api/src/StorageEventDispatcherImpl.h View 1 2 1 chunk +60 lines, -0 lines 0 comments Download
A webkit/api/src/StorageEventDispatcherImpl.cpp View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A webkit/api/src/WebStorageEventDispatcherImpl.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A webkit/api/src/WebStorageEventDispatcherImpl.cpp View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jorlow
11 years, 2 months ago (2009-10-01 20:28:32 UTC) #1
jorlow
11 years, 2 months ago (2009-10-01 23:00:05 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698