Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2580053002: Revert "DevTools: Add "New" button to launch timeline landing page."
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/toolbar.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index 8a2264638c5ededb34773e0bf0ef629c18b83fec..ee4b00e5fa4a005dd818d8382a51c1f40d49b3f7 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -293,10 +293,6 @@ Timeline.TimelinePanel = class extends UI.Panel {
// Record
if (Runtime.experiments.isEnabled('timelineLandingPage')) {
- const newButton = new UI.ToolbarButton(
- Common.UIString('New recording'), 'largeicon-add', Common.UIString('New'));
- newButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
- this._panelToolbar.appendToolbarItem(newButton);
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction));
this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('main.reload'));
} else if (Runtime.experiments.isEnabled('timelineRecordingPerspectives') &&
@@ -309,11 +305,9 @@ Timeline.TimelinePanel = class extends UI.Panel {
}
// Clear
- if (!Runtime.experiments.isEnabled('timelineLandingPage')) {
- const clearButton = new UI.ToolbarButton(Common.UIString('Clear recording'), 'largeicon-clear');
- clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
- this._panelToolbar.appendToolbarItem(clearButton);
- }
+ var clearButton = new UI.ToolbarButton(Common.UIString('Clear recording'), 'largeicon-clear');
+ clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);
+ this._panelToolbar.appendToolbarItem(clearButton);
this._panelToolbar.appendSeparator();
@@ -377,7 +371,6 @@ Timeline.TimelinePanel = class extends UI.Panel {
this._onModeChanged();
}
- // Checkboxes
if (Runtime.experiments.isEnabled('timelineLandingPage')) {
if (!this._model.isEmpty()) {
this._panelToolbar.appendToolbarItem(this._createSettingCheckbox(Common.UIString('Memory'),
@@ -428,16 +421,14 @@ Timeline.TimelinePanel = class extends UI.Panel {
this._panelToolbar.appendToolbarItem(checkbox);
}
}
+ this._panelToolbar.appendSeparator();
+ this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('components.collect-garbage'));
this._panelToolbar.appendSeparator();
this._cpuThrottlingCombobox = new UI.ToolbarComboBox(this._onCPUThrottlingChanged.bind(this));
this._panelToolbar.appendToolbarItem(this._createNetworkConditionsSelect());
this._panelToolbar.appendToolbarItem(this._cpuThrottlingCombobox);
this._populateCPUThrottingCombobox();
-
- this._panelToolbar.appendSeparator();
- this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButtonForId('components.collect-garbage'));
-
this._updateTimelineControls();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/toolbar.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698