Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: third_party/WebKit/Source/core/html/AutoplayUmaHelperTest.cpp

Issue 2580003002: Follow-up fix for leaking mock object in AutoplayUmaHelperTest (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/AutoplayUmaHelper.h" 5 #include "core/html/AutoplayUmaHelper.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/html/HTMLMediaElement.h" 8 #include "core/html/HTMLMediaElement.h"
9 #include "core/html/HTMLVideoElement.h" 9 #include "core/html/HTMLVideoElement.h"
10 #include "core/testing/DummyPageHolder.h" 10 #include "core/testing/DummyPageHolder.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 std::unique_ptr<DummyPageHolder>& pageHolder() { return m_pageHolder; } 50 std::unique_ptr<DummyPageHolder>& pageHolder() { return m_pageHolder; }
51 51
52 private: 52 private:
53 void SetUp() override { 53 void SetUp() override {
54 m_pageHolder = DummyPageHolder::create(IntSize(800, 600)); 54 m_pageHolder = DummyPageHolder::create(IntSize(800, 600));
55 document().documentElement()->setInnerHTML("<video id=video></video>", 55 document().documentElement()->setInnerHTML("<video id=video></video>",
56 ASSERT_NO_EXCEPTION); 56 ASSERT_NO_EXCEPTION);
57 HTMLMediaElement& element = mediaElement(); 57 HTMLMediaElement& element = mediaElement();
58 m_umaHelper = new MockAutoplayUmaHelper(&element); 58 m_umaHelper = new MockAutoplayUmaHelper(&element);
59 element.m_autoplayUmaHelper = m_umaHelper; 59 element.m_autoplayUmaHelper = m_umaHelper;
60 ::testing::Mock::AllowLeak(&umaHelper());
60 } 61 }
61 62
62 void TearDown() override { m_umaHelper.clear(); } 63 void TearDown() override { m_umaHelper.clear(); }
63 64
64 std::unique_ptr<DummyPageHolder> m_pageHolder; 65 std::unique_ptr<DummyPageHolder> m_pageHolder;
65 Persistent<MockAutoplayUmaHelper> m_umaHelper; 66 Persistent<MockAutoplayUmaHelper> m_umaHelper;
66 }; 67 };
67 68
68 TEST_F(AutoplayUmaHelperTest, VisibilityChangeWhenUnload) { 69 TEST_F(AutoplayUmaHelperTest, VisibilityChangeWhenUnload) {
69 EXPECT_CALL(umaHelper(), handleContextDestroyed()); 70 EXPECT_CALL(umaHelper(), handleContextDestroyed());
70 71
71 mediaElement().setMuted(true); 72 mediaElement().setMuted(true);
72 umaHelper().onAutoplayInitiated(AutoplaySource::Attribute); 73 umaHelper().onAutoplayInitiated(AutoplaySource::Attribute);
73 umaHelper().handlePlayingEvent(); 74 umaHelper().handlePlayingEvent();
74 pageHolder().reset(); 75 pageHolder().reset();
75 ::testing::Mock::VerifyAndClear(&umaHelper()); 76 ::testing::Mock::VerifyAndClear(&umaHelper());
76 } 77 }
77 78
78 } // namespace blink 79 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698