Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2579903002: Revert of [DevTools] Migrate ServiceWorker domain to new generator. (Closed)

Created:
4 years ago by dgozman
Modified:
4 years ago
Reviewers:
caseq
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ ) Reason for revert: Crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=674474 Original issue's description: > [DevTools] Migrate ServiceWorker domain to new generator. > > BUG=664683 > TBR=pfeldman > > Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f > Cr-Commit-Position: refs/heads/master@{#438676} TBR=caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664683

Patch Set 1 #

Patch Set 2 : manually #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -130 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.h View 1 4 chunks +32 lines, -19 lines 0 comments Download
M content/browser/devtools/protocol/service_worker_handler.cc View 1 8 chunks +109 lines, -93 lines 0 comments Download
M content/browser/devtools/protocol_config.json View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 6 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dgozman
Created Revert of [DevTools] Migrate ServiceWorker domain to new generator.
4 years ago (2016-12-15 22:07:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579903002/1
4 years ago (2016-12-15 22:08:06 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-15 22:08:54 UTC) #5
Failed to apply patch for
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:
While running git apply --index -p1;
  error: patch failed:
content/browser/devtools/protocol/devtools_protocol_handler_generator.py:643
  error:
content/browser/devtools/protocol/devtools_protocol_handler_generator.py: patch
does not apply

Patch:      
content/browser/devtools/protocol/devtools_protocol_handler_generator.py
Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py
diff --git
a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
index
60178dd04af6dce343c4a8593b917b17343c7b33..823d2185c409f3b6aaeb4f149525bdef285f4493
100755
--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
@@ -643,7 +643,7 @@
 includes = []
 fields_init = []
 
-browser_domains_list = ["Target", "Input"]
+browser_domains_list = ["Target", "ServiceWorker", "Input"]
 browser_commands_list = []
 async_commands_list = [
     "Input.synthesizePinchGesture",

Powered by Google App Engine
This is Rietveld 408576698