Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 257983003: [Telemetry] Disable testPagesetRepeat on win. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 8 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Disable testPagesetRepeat on win. It is failing and I suspect the problem is in the unittest not in the code under test, so I'm disabling rather than reverting the other change. File "E:\b\build\slave\XP_Tests__2_\build\src\tools\telemetry\telemetry\page\page_runner_unittest.py", line 240, in testPagesetRepeat os.remove(output_file) WindowsError: [Error 32] The process cannot access the file because it is being used by another process: 'c:\\docume~1\\chrome~2\\locals~1\\temp\\tmpiwpnmk' TBR=dalecurtis@chromium.org NOTRY=True NOTREECHECKS=True BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/page_runner_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-27 18:39:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/257983003/1
6 years, 8 months ago (2014-04-27 18:39:58 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-27 18:40:36 UTC) #3
Message was sent while issue was closed.
Change committed as 266411

Powered by Google App Engine
This is Rietveld 408576698