Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4887)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 257983002: Move downloads API to extensions namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index aa335fb528a1794cf69e4d02bf21c1e29434a451..b12a045bc71d22369f00fe4cd91a1ab3df0a008f 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -113,6 +113,8 @@ const char kUserGesture[] = "User gesture required";
namespace errors = download_extension_errors;
+namespace extensions {
+
namespace {
namespace downloads = extensions::api::downloads;
@@ -272,7 +274,8 @@ scoped_ptr<base::DictionaryValue> DownloadItemToJSON(
base::Time now = base::Time::Now();
json->SetString(kEstimatedEndTimeKey, TimeToISO8601(now + time_remaining));
}
- DownloadedByExtension* by_ext = DownloadedByExtension::Get(download_item);
+ DownloadedByExtension* by_ext =
Pam (message me for reviews) 2014/04/28 07:55:18 Extra newline
limasdf 2014/04/28 10:07:29 Done.
+ DownloadedByExtension::Get(download_item);
if (by_ext) {
json->SetString(kByExtensionIdKey, by_ext->id());
json->SetString(kByExtensionNameKey, by_ext->name());
@@ -1900,3 +1903,5 @@ void ExtensionDownloadsEventRouter::OnExtensionUnloaded(
if (iter != shelf_disabling_extensions_.end())
shelf_disabling_extensions_.erase(iter);
}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698