Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257983002: Move downloads API to extensions namespace (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 7 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move downloads API to extensions namespace BUG=117261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267073

Patch Set 1 : #

Total comments: 3

Patch Set 2 : feedback #

Patch Set 3 : fix compile error for unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+875 lines, -753 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/download/download_history.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/download/download_history_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/download/download_service.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/download/download_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 83 chunks +848 lines, -741 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 28 (0 generated)
limasdf
PTAL @pam for c/b/ui/webui review. @benjhayden for others. https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc File chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc (right): https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc#newcode66 chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc:66: namespace ...
6 years, 8 months ago (2014-04-26 07:39:39 UTC) #1
Pam (message me for reviews)
> @pam for c/b/ui/webui review. webui LGTM (and could have been TBR, for future reference) ...
6 years, 7 months ago (2014-04-28 07:55:10 UTC) #2
Pam (message me for reviews)
https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api.cc File chrome/browser/extensions/api/downloads/downloads_api.cc (right): https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api.cc#newcode277 chrome/browser/extensions/api/downloads/downloads_api.cc:277: DownloadedByExtension* by_ext = Extra newline
6 years, 7 months ago (2014-04-28 07:55:18 UTC) #3
limasdf
Thanks Pam. https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api.cc File chrome/browser/extensions/api/downloads/downloads_api.cc (right): https://codereview.chromium.org/257983002/diff/20001/chrome/browser/extensions/api/downloads/downloads_api.cc#newcode277 chrome/browser/extensions/api/downloads/downloads_api.cc:277: DownloadedByExtension* by_ext = On 2014/04/28 07:55:18, Pam ...
6 years, 7 months ago (2014-04-28 10:07:28 UTC) #4
benjhayden
lgtm
6 years, 7 months ago (2014-04-28 17:23:20 UTC) #5
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-28 22:12:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/30001
6 years, 7 months ago (2014-04-28 22:12:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:27:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 7 months ago (2014-04-28 22:27:10 UTC) #9
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-29 01:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/50001
6 years, 7 months ago (2014-04-29 01:01:10 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 01:07:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-29 01:07:27 UTC) #13
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-29 01:10:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/50001
6 years, 7 months ago (2014-04-29 01:10:43 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 01:46:21 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-29 01:46:22 UTC) #17
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-29 13:36:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/50001
6 years, 7 months ago (2014-04-29 13:36:42 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 13:49:41 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 13:49:41 UTC) #21
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-29 13:50:25 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/50001
6 years, 7 months ago (2014-04-29 13:50:51 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 14:43:58 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 14:43:59 UTC) #25
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 7 months ago (2014-04-29 17:49:55 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/257983002/50001
6 years, 7 months ago (2014-04-29 17:51:10 UTC) #27
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:01:43 UTC) #28
Message was sent while issue was closed. 
Change committed as 267073

Powered by Google App Engine
This is Rietveld 408576698