Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/android/password_ui_view_android.cc

Issue 2579823003: Remove Finch support for PasswordBranding (Closed)
Patch Set: Drop ShouldShowSavePromptFirstRunExperience Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/password_ui_view_android.h" 5 #include "chrome/browser/android/password_ui_view_android.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
11 #include "base/metrics/field_trial.h" 11 #include "base/metrics/field_trial.h"
12 #include "base/strings/string_piece.h" 12 #include "base/strings/string_piece.h"
13 #include "chrome/browser/profiles/profile_manager.h" 13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/sync/profile_sync_service_factory.h" 14 #include "chrome/browser/sync/profile_sync_service_factory.h"
15 #include "chrome/grit/generated_resources.h" 15 #include "chrome/grit/generated_resources.h"
16 #include "components/autofill/core/common/password_form.h" 16 #include "components/autofill/core/common/password_form.h"
17 #include "components/browser_sync/profile_sync_service.h" 17 #include "components/browser_sync/profile_sync_service.h"
18 #include "components/password_manager/core/browser/affiliation_utils.h" 18 #include "components/password_manager/core/browser/affiliation_utils.h"
19 #include "components/password_manager/core/browser/password_bubble_experiment.h" 19 #include "components/password_manager/core/browser/password_bubble_experiment.h"
vasilii 2016/12/16 16:56:53 seems to be unused.
vabr (Chromium) 2016/12/16 18:56:28 Done.
20 #include "components/password_manager/core/browser/password_manager_constants.h" 20 #include "components/password_manager/core/browser/password_manager_constants.h"
21 #include "components/password_manager/core/browser/password_ui_utils.h" 21 #include "components/password_manager/core/browser/password_ui_utils.h"
22 #include "components/password_manager/core/common/experiments.h" 22 #include "components/password_manager/core/common/experiments.h"
vasilii 2016/12/16 16:56:53 unused, maybe other headers too.
vabr (Chromium) 2016/12/16 18:56:27 Indeed, the affiliation_utils seemed unused as wel
23 #include "jni/PasswordUIView_jni.h" 23 #include "jni/PasswordUIView_jni.h"
24 #include "ui/base/l10n/l10n_util.h" 24 #include "ui/base/l10n/l10n_util.h"
25 25
26 using base::android::ConvertUTF16ToJavaString; 26 using base::android::ConvertUTF16ToJavaString;
27 using base::android::ConvertUTF8ToJavaString; 27 using base::android::ConvertUTF8ToJavaString;
28 using base::android::JavaParamRef; 28 using base::android::JavaParamRef;
29 using base::android::ScopedJavaLocalRef; 29 using base::android::ScopedJavaLocalRef;
30 30
31 namespace { 31 namespace {
32 32
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 password_manager_presenter_.RemovePasswordException(index); 142 password_manager_presenter_.RemovePasswordException(index);
143 } 143 }
144 144
145 ScopedJavaLocalRef<jstring> GetAccountDashboardURL( 145 ScopedJavaLocalRef<jstring> GetAccountDashboardURL(
146 JNIEnv* env, 146 JNIEnv* env,
147 const JavaParamRef<jclass>&) { 147 const JavaParamRef<jclass>&) {
148 return ConvertUTF8ToJavaString( 148 return ConvertUTF8ToJavaString(
149 env, password_manager::kPasswordManagerAccountDashboardURL); 149 env, password_manager::kPasswordManagerAccountDashboardURL);
150 } 150 }
151 151
152 static jboolean ShouldUseSmartLockBranding(JNIEnv* env,
153 const JavaParamRef<jclass>&) {
154 const browser_sync::ProfileSyncService* sync_service =
155 ProfileSyncServiceFactory::GetForProfile(
156 ProfileManager::GetLastUsedProfile());
157 return password_bubble_experiment::IsSmartLockBrandingEnabled(sync_service);
158 }
159
160 // static 152 // static
161 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) { 153 static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
162 PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj); 154 PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj);
163 return reinterpret_cast<intptr_t>(controller); 155 return reinterpret_cast<intptr_t>(controller);
164 } 156 }
165 157
166 bool PasswordUIViewAndroid::RegisterPasswordUIViewAndroid(JNIEnv* env) { 158 bool PasswordUIViewAndroid::RegisterPasswordUIViewAndroid(JNIEnv* env) {
167 return RegisterNativesImpl(env); 159 return RegisterNativesImpl(env);
168 } 160 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698