Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: Source/core/rendering/RenderTextTrackCue.cpp

Issue 25798003: Enable WebVTT regions for runtime testing, updated tests and minor fixes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revert Logging Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTextTrackCue.cpp
diff --git a/Source/core/rendering/RenderTextTrackCue.cpp b/Source/core/rendering/RenderTextTrackCue.cpp
index e54e923cf1b35a2c8d2f490028ee433263a43790..62bb2aff78c20977077d8a86180c34ac530d5616 100644
--- a/Source/core/rendering/RenderTextTrackCue.cpp
+++ b/Source/core/rendering/RenderTextTrackCue.cpp
@@ -24,9 +24,9 @@
*/
#include "config.h"
-
#include "core/rendering/RenderTextTrackCue.h"
+#include "RuntimeEnabledFeatures.h"
#include "core/html/track/TextTrackCue.h"
#include "core/html/track/TextTrackCueGeneric.h"
#include "core/rendering/RenderView.h"
@@ -43,14 +43,12 @@ void RenderTextTrackCue::layout()
{
RenderBlockFlow::layout();
-#if ENABLE(WEBVTT_REGIONS)
// If WebVTT Regions are used, the regular WebVTT layout algorithm is no
// longer necessary, since cues having the region parameter set do not have
// any positioning parameters. Also, in this case, the regions themselves
// have positioning information.
- if (!m_cue->regionId().isEmpty())
+ if (RuntimeEnabledFeatures::webVTTRegionsEnabled() && !m_cue->regionId().isEmpty())
acolwell GONE FROM CHROMIUM 2013/10/04 19:48:20 nit: If regionId's can't be non-empty w/o the flag
vcarbune.chromium 2013/10/08 18:07:38 Done.
return;
-#endif
LayoutStateMaintainer statePusher(view(), this, locationOffset(), hasTransform() || hasReflection() || style()->isFlippedBlocksWritingMode());
« Source/core/page/RuntimeEnabledFeatures.in ('K') | « Source/core/page/RuntimeEnabledFeatures.in ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698