Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: Source/core/html/track/LoadableTextTrack.cpp

Issue 25798003: Enable WebVTT regions for runtime testing, updated tests and minor fixes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/LoadableTextTrack.cpp
diff --git a/Source/core/html/track/LoadableTextTrack.cpp b/Source/core/html/track/LoadableTextTrack.cpp
index 9ccb64b53af3cd7ff940c116f49877a865306d9d..b0c83bbcd0fadaf837b12d20c2f716a38006e674 100644
--- a/Source/core/html/track/LoadableTextTrack.cpp
+++ b/Source/core/html/track/LoadableTextTrack.cpp
@@ -24,9 +24,9 @@
*/
#include "config.h"
-
#include "core/html/track/LoadableTextTrack.h"
+#include "RuntimeEnabledFeatures.h"
acolwell GONE FROM CHROMIUM 2013/10/08 22:09:06 nit: Not needed.
vcarbune.chromium 2013/10/12 22:33:55 Done.
#include "core/html/HTMLTrackElement.h"
#include "core/html/track/TextTrackCueList.h"
#include "core/html/track/TextTrackRegionList.h"
@@ -128,7 +128,6 @@ void LoadableTextTrack::cueLoadingCompleted(TextTrackLoader* loader, bool loadin
m_trackElement->didCompleteLoad(this, loadingFailed ? HTMLTrackElement::Failure : HTMLTrackElement::Success);
}
-#if ENABLE(WEBVTT_REGIONS)
void LoadableTextTrack::newRegionsAvailable(TextTrackLoader* loader)
{
ASSERT_UNUSED(loader, m_loader == loader);
@@ -138,10 +137,9 @@ void LoadableTextTrack::newRegionsAvailable(TextTrackLoader* loader)
for (size_t i = 0; i < newRegions.size(); ++i) {
newRegions[i]->setTrack(this);
- regionList()->add(newRegions[i]);
+ regions()->add(newRegions[i]);
}
}
-#endif
size_t LoadableTextTrack::trackElementIndex()
{

Powered by Google App Engine
This is Rietveld 408576698