third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc - Issue 2579773002: Use WTF::Deque instead of std::queue in the blink scheduler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc

Issue 2579773002: Use WTF::Deque instead of std::queue in the blink scheduler (Closed)

Patch Set: Apply the fix Sami suggested Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/work_queue.cc ('k') | third_party/WebKit/Source/wtf/Deque.h » ('j') | third_party/WebKit/Source/wtf/Deque.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc

index caff18230cfa2f8c85702d81185e925de36bebe3..7b11f44046261f1c612fb3b1e34c26ed32b31ddc 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/work_queue_unittest.cc

@@ -32,7 +32,7 @@ class WorkQueueTest : public testing::Test {

work_queue_sets_.reset(new WorkQueueSets(1, "test"));

work_queue_sets_->AddQueue(work_queue_.get(), 0);

- incoming_queue_.reset(new std::queue<TaskQueueImpl::Task>());

+ incoming_queue_.reset(new WTF::Deque<TaskQueueImpl::Task>());

}

void TearDown() override { work_queue_sets_->RemoveQueue(work_queue_.get()); }

@@ -49,7 +49,7 @@ class WorkQueueTest : public testing::Test {

scoped_refptr<TaskQueueImpl> task_queue_;

std::unique_ptr<WorkQueue> work_queue_;

std::unique_ptr<WorkQueueSets> work_queue_sets_;

- std::unique_ptr<std::queue<TaskQueueImpl::Task>> incoming_queue_;

+ std::unique_ptr<WTF::Deque<TaskQueueImpl::Task>> incoming_queue_;

};

TEST_F(WorkQueueTest, Empty) {

@@ -124,9 +124,9 @@ TEST_F(WorkQueueTest, PushAfterFenceHit) {

}

TEST_F(WorkQueueTest, SwapLocked) {

- incoming_queue_->push(FakeTaskWithEnqueueOrder(2));

- incoming_queue_->push(FakeTaskWithEnqueueOrder(3));

- incoming_queue_->push(FakeTaskWithEnqueueOrder(4));

+ incoming_queue_->push_back(FakeTaskWithEnqueueOrder(2));

+ incoming_queue_->push_back(FakeTaskWithEnqueueOrder(3));

+ incoming_queue_->push_back(FakeTaskWithEnqueueOrder(4));

WorkQueue* work_queue;

EXPECT_FALSE(work_queue_sets_->GetOldestQueueInSet(0, &work_queue));

@@ -146,9 +146,9 @@ TEST_F(WorkQueueTest, SwapLocked) {

TEST_F(WorkQueueTest, SwapLockedAfterFenceHit) {

work_queue_->InsertFence(1);