Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2579693005: Remove legacy constants on Event (Closed)

Created:
4 years ago by foolip
Modified:
3 years, 11 months ago
Reviewers:
tkent, timvolodine
CC:
android-webview-reviews_chromium.org, blink-reviews, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, shimazu+serviceworker_chromium.org, tfarina, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update newly imported wpt/dom/historical.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -358 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constants.html View 5 chunks +7 lines, -39 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constants-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-get-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/workers/worker-importScriptsOnError-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt View 1 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.idl View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
foolip
PTAL. I'll wait for 3xLGTM on blink-dev before landing of course.
4 years ago (2016-12-17 19:17:31 UTC) #8
tkent
lgtm
4 years ago (2016-12-21 04:10:58 UTC) #9
foolip
timvolodine@, please review android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
4 years ago (2016-12-21 10:08:51 UTC) #13
foolip
On 2016/12/21 10:08:51, foolip (OOO until Jan 2) wrote: > timvolodine@, please review > android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt ...
3 years, 11 months ago (2017-01-02 09:30:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579693005/20001
3 years, 11 months ago (2017-01-02 09:30:57 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/361387)
3 years, 11 months ago (2017-01-02 11:45:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2579693005/20001
3 years, 11 months ago (2017-01-02 16:13:20 UTC) #24
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3d7205bd4386ca9608b0ed138998bcba7d0a3cac Cr-Commit-Position: refs/heads/master@{#441075}
3 years, 11 months ago (2017-01-02 18:34:16 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 18:35:00 UTC) #28
Message was sent while issue was closed.
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698