Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: services/ui/ws/server_window_compositor_frame_sink_manager.cc

Issue 2579693004: GpuCompositorFrameSink implements cc::mojom::DisplayPrivate (Closed)
Patch Set: Added //ipc to public_deps in color_space.typemap Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/server_window_compositor_frame_sink_manager.cc
diff --git a/services/ui/ws/server_window_compositor_frame_sink_manager.cc b/services/ui/ws/server_window_compositor_frame_sink_manager.cc
index b89eb1940b467eac29ab2a550d701a795aa3b60c..259d5d4b099428053ad962b28deb11e8cd720c5c 100644
--- a/services/ui/ws/server_window_compositor_frame_sink_manager.cc
+++ b/services/ui/ws/server_window_compositor_frame_sink_manager.cc
@@ -38,19 +38,22 @@ bool ServerWindowCompositorFrameSinkManager::ShouldDraw() {
void ServerWindowCompositorFrameSinkManager::CreateDisplayCompositorFrameSink(
gfx::AcceleratedWidget widget,
cc::mojom::MojoCompositorFrameSinkRequest request,
- cc::mojom::MojoCompositorFrameSinkClientPtr client) {
- CreateCompositorFrameSinkInternal(mojom::CompositorFrameSinkType::DEFAULT,
- widget, std::move(request),
- std::move(client));
+ cc::mojom::MojoCompositorFrameSinkClientPtr client,
+ cc::mojom::DisplayPrivatePtr display_private,
Fady Samuel 2016/12/16 05:29:39 don't pass this in
Alex Z. 2016/12/16 16:42:00 Done.
+ cc::mojom::DisplayPrivateRequest display_request) {
Fady Samuel 2016/12/16 05:29:39 display_private_request
Alex Z. 2016/12/16 16:42:00 Done.
+ display_private_ = std::move(display_private);
Fady Samuel 2016/12/16 05:29:39 don't store this.
Alex Z. 2016/12/16 16:42:00 Done.
+ CreateCompositorFrameSinkInternal(
+ mojom::CompositorFrameSinkType::DEFAULT, widget, std::move(request),
+ std::move(client), std::move(display_request));
}
void ServerWindowCompositorFrameSinkManager::CreateOffscreenCompositorFrameSink(
mojom::CompositorFrameSinkType compositor_frame_sink_type,
cc::mojom::MojoCompositorFrameSinkRequest request,
cc::mojom::MojoCompositorFrameSinkClientPtr client) {
- CreateCompositorFrameSinkInternal(compositor_frame_sink_type,
- gfx::kNullAcceleratedWidget,
- std::move(request), std::move(client));
+ CreateCompositorFrameSinkInternal(
+ compositor_frame_sink_type, gfx::kNullAcceleratedWidget,
+ std::move(request), std::move(client), nullptr);
}
void ServerWindowCompositorFrameSinkManager::AddChildFrameSinkId(
@@ -132,7 +135,8 @@ void ServerWindowCompositorFrameSinkManager::CreateCompositorFrameSinkInternal(
mojom::CompositorFrameSinkType compositor_frame_sink_type,
gfx::AcceleratedWidget widget,
cc::mojom::MojoCompositorFrameSinkRequest request,
- cc::mojom::MojoCompositorFrameSinkClientPtr client) {
+ cc::mojom::MojoCompositorFrameSinkClientPtr client,
+ cc::mojom::DisplayPrivateRequest display_request) {
cc::FrameSinkId frame_sink_id(
WindowIdToTransportId(window_->id()),
static_cast<uint32_t>(compositor_frame_sink_type));
@@ -153,7 +157,8 @@ void ServerWindowCompositorFrameSinkManager::CreateCompositorFrameSinkInternal(
->GetDisplayCompositor()
->CreateDisplayCompositorFrameSink(
frame_sink_id, widget, std::move(request),
- std::move(private_request), std::move(client));
+ std::move(private_request), std::move(client),
+ std::move(display_request));
Fady Samuel 2016/12/16 05:29:39 nit: display_private_request
Alex Z. 2016/12/16 16:42:00 Done.
} else {
window_->delegate()
->GetDisplayCompositor()

Powered by Google App Engine
This is Rietveld 408576698