Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3331)

Unified Diff: cc/ipc/display_compositor.mojom

Issue 2579693004: GpuCompositorFrameSink implements cc::mojom::DisplayPrivate (Closed)
Patch Set: Address comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/ipc/display_compositor.mojom
diff --git a/cc/ipc/display_compositor.mojom b/cc/ipc/display_compositor.mojom
index 06abdbd55d3d1ec4b2b64cde7f43aa327679764b..dd1e371c0fddc754e17485c4f8eb6330a1b08257 100644
--- a/cc/ipc/display_compositor.mojom
+++ b/cc/ipc/display_compositor.mojom
@@ -9,7 +9,19 @@ import "cc/ipc/mojo_compositor_frame_sink.mojom";
import "cc/ipc/surface_id.mojom";
import "cc/ipc/surface_sequence.mojom";
import "gpu/ipc/common/surface_handle.mojom";
+import "mojo/common/time.mojom";
import "ui/gfx/geometry/mojo/geometry.mojom";
+import "ui/gfx/mojo/color_space.mojom";
+
+// See ui/compositor/compositor.h: ContextFactoryPrivate.
+// The DisplayPrivate is used by privileged clients to talk to cc::Display.
+// DisplayPrivate would eventually replace or be used by ContextFactoryPrivate.
+interface DisplayPrivate {
+ SetDisplayVisible(bool visible);
+ ResizeDisplay(gfx.mojom.Size size_in_pixel);
+ SetDisplayColorSpace(gfx.mojom.ColorSpace color_space);
+ SetOutputIsSecure(bool secure);
+};
// The DisplayCompositor interface is a privileged interface that allows
// the display compositor host (browser or window server) to create
@@ -23,13 +35,20 @@ import "ui/gfx/geometry/mojo/geometry.mojom";
// will typically simply request a CompositorFrameSink from the display
// compositor host which will forward the request to the display compositor.
interface DisplayCompositor {
+ // Create a CompositorFrameSink for a privileged client (e.g. WindowServer).
+ // This is only used by privileged clients. The client can call methods that
+ // talks to the cc::Display (e.g. ResizeDisplay(), SetDisplayVisible(), etc)
CreateDisplayCompositorFrameSink(
cc.mojom.FrameSinkId frame_sink_id,
gpu.mojom.SurfaceHandle widget,
cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,
cc.mojom.MojoCompositorFrameSinkPrivate& compositor_frame_sink_private,
- cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client);
+ cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client,
+ DisplayPrivate& display_private);
+ // CreateOffscreenCompositorFrameSink is used by unprivileged clients.
+ // An off screen CompositorFrameSink only submits frames to a buffer instead
+ // of a display.
CreateOffscreenCompositorFrameSink(
cc.mojom.FrameSinkId frame_sink_id,
cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,

Powered by Google App Engine
This is Rietveld 408576698