GpuCompositorFrameSink implements cc::mojom::DisplayPrivate

cc/ipc/display_compositor.mojom

Index: cc/ipc/display_compositor.mojom
diff --git a/cc/ipc/display_compositor.mojom b/cc/ipc/display_compositor.mojom
index 06abdbd55d3d1ec4b2b64cde7f43aa327679764b..ec1a4280f7a7ea45ca9e0ad7ee49acbcc45e29bd 100644
--- a/cc/ipc/display_compositor.mojom
+++ b/cc/ipc/display_compositor.mojom
@@ -9,7 +9,17 @@ import "cc/ipc/mojo_compositor_frame_sink.mojom";
 import "cc/ipc/surface_id.mojom";
 import "cc/ipc/surface_sequence.mojom";
 import "gpu/ipc/common/surface_handle.mojom";
+import "mojo/common/time.mojom";
 import "ui/gfx/geometry/mojo/geometry.mojom";
+import "ui/gfx/mojo/color_space.mojom";
+
+// See cc//surfaces/display.h

[Tom Sepez, 2016/12/19 20:14:23]

nit: path typo

[Alex Z., 2016/12/19 20:28:27]

Done.

+interface DisplayPrivate {
+  SetDisplayVisible(bool visible);
+  ResizeDisplay(gfx.mojom.Size size_in_pixel);
+  SetDisplayColorSpace(gfx.mojom.ColorSpace color_space);
+  SetOutputIsSecure(bool secure);

[Tom Sepez, 2016/12/19 20:14:23]

I know its pre-existing, but could you explain what the implications are of
something being "secure"?

[Alex Z., 2016/12/19 20:28:27]

It indicates if the output content is secure DRM-wise. The value ends up in
SurfaceAggregator. SurfaceAggregator only draws the actual content if output is
secure, it draws a solid color otherwise.

+};
 
 // The DisplayCompositor interface is a privileged interface that allows
 // the display compositor host (browser or window server) to create
@@ -23,13 +33,20 @@ import "ui/gfx/geometry/mojo/geometry.mojom";
 // will typically simply request a CompositorFrameSink from the display
 // compositor host which will forward the request to the display compositor.
 interface DisplayCompositor {
+  // Create a CompositorFrameSink for a privileged client (e.g. WindowServer).
+  // This is only used by privileged clients. The client can call methods that
+  // talks to the cc::Display (e.g. ResizeDisplay(), SetDisplayVisible(), etc)
   CreateDisplayCompositorFrameSink(
       cc.mojom.FrameSinkId frame_sink_id,
       gpu.mojom.SurfaceHandle widget,
       cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,
       cc.mojom.MojoCompositorFrameSinkPrivate& compositor_frame_sink_private,
-      cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client);
+      cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client,
+      DisplayPrivate& display_private);
 
+  // CreateOffscreenCompositorFrameSink is used by non-privileged clients.
+  // An off screen CompositorFrameSink only submits frames to a buffer instead
+  // of a display.
   CreateOffscreenCompositorFrameSink(
       cc.mojom.FrameSinkId frame_sink_id,
       cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,