GpuCompositorFrameSink implements cc::mojom::DisplayPrivate

cc/ipc/display_compositor.mojom

Index: cc/ipc/display_compositor.mojom
diff --git a/cc/ipc/display_compositor.mojom b/cc/ipc/display_compositor.mojom
index 06abdbd55d3d1ec4b2b64cde7f43aa327679764b..3c1cfb322ad7761916acfcb5a2ab16facb262d84 100644
--- a/cc/ipc/display_compositor.mojom
+++ b/cc/ipc/display_compositor.mojom
@@ -9,7 +9,9 @@ import "cc/ipc/mojo_compositor_frame_sink.mojom";
 import "cc/ipc/surface_id.mojom";
 import "cc/ipc/surface_sequence.mojom";
 import "gpu/ipc/common/surface_handle.mojom";
+import "mojo/common/time.mojom";
 import "ui/gfx/geometry/mojo/geometry.mojom";
+import "ui/gfx/mojo/color_space.mojom";
 
 // The DisplayCompositor interface is a privileged interface that allows
 // the display compositor host (browser or window server) to create
@@ -28,7 +30,8 @@ interface DisplayCompositor {
       gpu.mojom.SurfaceHandle widget,
       cc.mojom.MojoCompositorFrameSink& compositor_frame_sink,
       cc.mojom.MojoCompositorFrameSinkPrivate& compositor_frame_sink_private,
-      cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client);
+      cc.mojom.MojoCompositorFrameSinkClient compositor_frame_sink_client,
+      DisplayPrivate& display_private);
 
   CreateOffscreenCompositorFrameSink(
       cc.mojom.FrameSinkId frame_sink_id,
@@ -53,3 +56,13 @@ interface DisplayCompositorClient {
                    gfx.mojom.Size frame_size,
                    float device_scale_factor);
 };
+
+// The DisplayPrivate is implemented by GpuCompositorFrameSink. It is used so
+// that ContextFactory can talk to cc::Display without knowing about
+// cc::Display.

[Fady Samuel, 2016/12/16 17:18:18]

nit: I would not reference GpuCompositorFrameSink here, nor would I reference
ContextFactory because those are in different layers of the system. Maybe simply
say // See cc/surfaces/display.h

Almost move this above the DisplayCompositor interface. This should be near the
top of the file. That's simply easier for readability.
CreateDisplayCompositorFrameSink uses this interface, and so it would be nice to
encounter this interface first in the file.

[Alex Z., 2016/12/19 19:27:47]

Done.

+interface DisplayPrivate {

[kylechar, 2016/12/16 17:08:32]

Is it DisplayPrivate just to disambiguate it from other things named Display?

+  SetDisplayVisible(bool visible);
+  ResizeDisplay(gfx.mojom.Size size);

[sadrul, 2016/12/16 17:12:05]

Can you add a comment to mention whether |size| is in DIP or physical pixel
space?

[danakj, 2016/12/16 17:13:41]

Or name it size_in_dip size_in_physical_pixels or the like

[Alex Z., 2016/12/19 19:27:47]

Done.

+  SetDisplayColorSpace(gfx.mojom.ColorSpace color_space);
+  SetOutputIsSecure(bool secure);
+};