GpuCompositorFrameSink implements cc::mojom::DisplayPrivate

services/ui/ws/server_window.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_UI_WS_SERVER_WINDOW_H_
 #define SERVICES_UI_WS_SERVER_WINDOW_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/observer_list.h"
+#include "cc/ipc/display_compositor.mojom.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "services/ui/public/interfaces/window_tree.mojom.h"
 #include "services/ui/ws/ids.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/vector2d.h"
 #include "ui/gfx/transform.h"
 #include "ui/platform_window/text_input_state.h"
 
 namespace ui {
@@ skipping 24 matching lines @@
                const WindowId& id,
                const Properties& properties);
   ~ServerWindow();
 
   void AddObserver(ServerWindowObserver* observer);
   void RemoveObserver(ServerWindowObserver* observer);
   bool HasObserver(ServerWindowObserver* observer);
 
   // Creates a new CompositorFrameSink of the specified type, replacing the
   // existing.
   // TODO(fsamuel): We should not be passing in |gpu_memory_buffer_manager| and

[msw, 2016/12/19 20:18:11]

tangential q: this TODO seems out of date; should it be removed/updated?

[Fady Samuel, 2016/12/19 20:20:18]

Yes, this TODO was addressed a while ago and can be deleted.

[Alex Z., 2016/12/19 20:53:29]

Done.

   // |context_provider|. The window server should not know anything about them.
   // Instead, they should be a CompositorFrameSink service-side implementation
   // detail.
   void CreateDisplayCompositorFrameSink(
       gfx::AcceleratedWidget widget,
       cc::mojom::MojoCompositorFrameSinkRequest request,
-      cc::mojom::MojoCompositorFrameSinkClientPtr client);
+      cc::mojom::MojoCompositorFrameSinkClientPtr client,

[msw, 2016/12/19 20:18:11]

tangential q: Shouldn't this file #include
"cc/ipc/mojo_compositor_frame_sink.mojom.h"?

[Fady Samuel, 2016/12/19 20:20:18]

+1

[Alex Z., 2016/12/19 20:53:29]

Done.

+      cc::mojom::DisplayPrivateRequest display_private_request);
   void CreateOffscreenCompositorFrameSink(
       mojom::CompositorFrameSinkType compositor_frame_sink_type,
       cc::mojom::MojoCompositorFrameSinkRequest request,
       cc::mojom::MojoCompositorFrameSinkClientPtr client);
 
   const WindowId& id() const { return id_; }
 
   void Add(ServerWindow* child);
   void Remove(ServerWindow* child);
   void Reorder(ServerWindow* relative, mojom::OrderDirection diretion);
@@ skipping 189 matching lines @@
 
   base::ObserverList<ServerWindowObserver> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(ServerWindow);
 };
 
 }  // namespace ws
 }  // namespace ui
 
 #endif  // SERVICES_UI_WS_SERVER_WINDOW_H_